After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593564 - ellipsis changes
ellipsis changes
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks: 621639
 
 
Reported: 2009-08-30 15:42 UTC by Philip Withnall
Modified: 2013-12-06 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
String fixes for gnome-bluetooth (10.16 KB, patch)
2009-08-30 15:42 UTC, Philip Withnall 		none Details | Review
Ellipsis changes (8.60 KB, patch)
2009-09-18 13:24 UTC, Philip Withnall 		none Details | Review
Other gnome-bluetooth string changes (1.94 KB, patch)
2009-09-18 13:25 UTC, Philip Withnall 		none Details | Review
Other gnome-bluetooth string changes (updated) (1.38 KB, patch)
2009-09-20 07:00 UTC, Philip Withnall 		committed Details | Review
all: Ellipsis changes (2.82 KB, patch)
2013-12-06 12:44 UTC, Bastien Nocera 		committed Details | Review

Description Philip Withnall 2009-08-30 15:42:34 UTC 
Created attachment 142074 [details] [review]
String fixes for gnome-bluetooth

Patch coming up with a load of fixes to use the proper ellipsis character ("…")
instead of three dots ("..."), as well as to use "PIN" instead of "PIN code" in
one place (for consistency) and "set up" instead of "setup" in one place (for
correctness).
Comment 1 Bastien Nocera 2009-09-01 16:49:08 UTC 
I don't agree with the ellipsis changes. Those would need to be documented in the HIG, and used all over the platform. As it stands, GTK+ still uses ... rather than …

Rest looks fine, mind splitting this up in separate patches?
Comment 2 Philip Withnall 2009-09-18 13:24:44 UTC 
Created attachment 143442 [details] [review]
Ellipsis changes

The ellipsis changes.
Comment 3 Philip Withnall 2009-09-18 13:25:10 UTC 
Created attachment 143443 [details] [review]
Other gnome-bluetooth string changes

The other (three) changes.
Comment 4 Bastien Nocera 2009-09-19 15:19:59 UTC 
(In reply to comment #3)
> Created an attachment (id=143443) [details]
> Other gnome-bluetooth string changes
> 
> The other (three) changes.

Committed the 2nd hunk now.

Could you please update your patch?
Comment 5 Philip Withnall 2009-09-20 07:00:06 UTC 
Created attachment 143506 [details] [review]
Other gnome-bluetooth string changes (updated)
Comment 6 Philip Withnall 2010-12-26 12:33:20 UTC 
Ping? What's happening about this patch (which doesn't contain ellipsis changes)?
Comment 7 Bastien Nocera 2010-12-26 13:25:21 UTC 
(In reply to comment #6)
> Ping? What's happening about this patch (which doesn't contain ellipsis
> changes)?

I don't know which patch you're talking about. One of them you marked as committed, and the other is called "ellipsis changes", so it most likely contains ellipsis changes ;)
Comment 8 Philip Withnall 2010-12-26 15:26:20 UTC 
Oh bother, I didn't notice it was marked as "committed" in the patch list. Ignore me.
Comment 9 Bastien Nocera 2013-12-06 12:44:47 UTC 
Created attachment 263660 [details] [review]
all: Ellipsis changes

Changes "..." to "…"
Comment 10 Bastien Nocera 2013-12-06 12:46:20 UTC 
Attachment 263660 [details] pushed as 5c5a126 - all: Ellipsis changes