After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 591571 - Removing a keyframe is not easy
Removing a keyframe is not easy
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
0.13.x
Other All
: Normal minor
: 0.13.3
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-12 15:13 UTC by antistress
Modified: 2009-09-03 05:52 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description antistress 2009-08-12 15:13:46 UTC
As i said in Bug 589817 (c#5), since this bug is fixed it's much harder than before to remove a keyframe by clicking again on it : it tends to add another keyframe.
I think that it may be a side effect of fixing bug 589817.
If it's true, i suggest 3 way to fix that :
1°) as for bug 589817, PiTiVi could be smart enough to help the user : if, considering the timeline zoom factor, user clicks on the timeline very close to an existing keyframe, we can assume it is an attempt to remove that keyframe. Then PiTiVi should remove that keyframe and not creating another keyframe so close to the former one.
2°) keyframe could be removed by an entry in the contextual menu instead of clicking again on an existing keyframe
3°) since Bug 589814 will lead to create percentage tooltips, that tooltip could show a cross (similar to firefox tabs) to remove the keyframe


Other information:
Comment 1 antistress 2009-08-12 15:21:28 UTC
i don't know if 3°) can also be used for video curves (will there be tooltips ?) : of course the way to remove keyframes must be the same for audio & video curves
Comment 2 Brandon Lewis 2009-08-13 06:00:51 UTC
I think this has mainly to do with poor feedback. If the keyframe under the mouse hilighted, you could be sure that you were targeting the keyframe and not the curve itself.

The value labels on keyframes will mostl likely be drawn directly, not implemented as tooltips.
Comment 3 Brandon Lewis 2009-08-17 22:52:31 UTC
try the bug_591571 in my repository and let me know if you think this solves the problem.
Comment 4 Brandon Lewis 2009-08-18 19:06:48 UTC
commit d944c4606d8e07c623f5180a0d85b65783ee331a
Author: Brandon Lewis <brandon_lewis@berkeley.edu>
Date:   Mon Aug 17 13:50:50 2009 -0700

    curve.py: also set focus keyframe on enter events
    keyframes should now be much easier to manipulate
    which should close bug 591571
Comment 5 Jean-François Fortin Tam 2009-08-19 12:59:37 UTC
Did you forget to push that branch?
Comment 6 antistress 2009-08-30 22:09:26 UTC
i tried the jaunty PPA :
that's very good, thanks