GNOME Bugzilla – Bug 589808
Set always-show-image on some menu items
Last modified: 2009-12-05 11:08:40 UTC
Since bug #557469 (set menus_have_icons=false by default), menu items which represent objects like devices or files should have a menu item. For totem, this would mean setting always-show-image for the devices and recent files in the Movie menu. At the moment, when running totem with menus_have_icons=false, no icons will be shown at all. I couldn't find out how to set this property because we're using GtkUIManager and GtkActions and not GtkImageMenuItems directly.
Created attachment 139255 [details] [review] always-show-image for devices and recent files Ok, it can be done with gtk_ui_manager_get_widget. This patch makes icons of devices and recent files always show.
If we're going to do that across GNOME, then it needs to be fixed properly in GtkUIManager. I have too many hacks of that sort in gnome-bluetooth already.
Christian Persch just filed bug #589842 for that.
*** Bug 590660 has been marked as a duplicate of this bug. ***
This makes the changes in time for the UI freeze; now the bug can be for updating them once bug #589842 is fixed. commit 2aff9b91410a9223822680cb577c2f2dc6f036c3 Author: Robin Stocker <robin@nibor.org> Date: Sat Aug 8 21:27:08 2009 +0100 Bug 589808 – Set always-show-image on some menu items src/totem-menu.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)
Created attachment 149120 [details] [review] Replace hack to set always-show-image for devices Now that we depend on GTK+ 2.19.1, we can remove the hack again. Ok to commit?
Yeppers, go for it.
commit 2933258789b8e6de00ebc1c0db0b3b628395be54 Author: Robin Stocker <robin@nibor.org> Date: Fri Dec 4 21:50:48 2009 +0100 Replace hack to set always-show-image for devices https://bugzilla.gnome.org/show_bug.cgi?id=589808 src/totem-menu.c | 11 +---------- 1 files changed, 1 insertions(+), 10 deletions(-)