GNOME Bugzilla – Bug 588054
support notify-osd bigger icons
Last modified: 2018-05-22 13:35:50 UTC
If you use notify-osd instead of notification-daemon you don't have to resize the icon before sending it.
Created attachment 138030 [details] [review] notify-osd-resize.patch
mmmm this patch causes a segfault somewhere...
Created attachment 138034 [details] [review] notify-osd-resize.patch I previously attached a wrong version of the patch. anyway it still segfaults during notify_get_server_info(&server_name, NULL, NULL, NULL);
Created attachment 138067 [details] [review] notify-osd-resize.patch It still crashes... Can someone without ubuntu karmic test it? I suspect the fault is in my version of notify-osd
This is a bug in libnotify. I just filed a bug in Debian with a patch (which will get synced to Ubuntu). (FYI, the patch for libnotify is at http://jdl.ducs.org.uk/misc/libnotify.diff.txt)
Thanks a lot, so it's better to wait before commits. Anyway I'm wondering if my patch can be improved, completely removing the resize of the icon, which is left to notify-osd... How much overhead does a double resize introduce? Do you think it's worth a try? (empathy does not offer a method to return not resized avatars, which should be implemented)
Is it really necessary to resize the icon if notification-daemon is not used?
As I've written in my previous comment, no. To do it some refactoring is needed, but now I don't have time
I've had a look at the code. It's really too hard. This is the right compromise
I don't believe that we should be adding implementation specific code. The approach seems completely wrong.
This is simply because of the poor implementation of notification-daemon. If you don't want to support notify-osd simply reject this, which will be added into ubuntu Anyway lots of softwares added this support, this is not the first request.
Another thing we can add for notify-osd is the concatenation of notifications: currently if you receive 2 messages from the same contact, the first bubble is immediately replaced by the following one. Instead it would be possible to merge the 2 bubbles so that the text is added, instead of replaced (so you have the time to read also the first bubble). I'm looking for some documentation about this
Created attachment 139281 [details] [review] notify-osd.patch patch for resize option, new message icon, x-canonical-append hint.
Thanks for your patch Nicolo. I do like the idea to cache all the capabilities of the server. I started to refactor the notify code and add a new object doing that (bug #601691). Once this branch is merged, we could consider to use it to change the size of icons if needed (let's focus on icons in this bug, bug #589851 is about the 'append'). Tbh I'm not convinced that checking the name of the server is the best way to do that. How is it done in other apps? Wouldn't it be possible to have a capabilities for that instead?
Hi back, here [1] is a page containing notification guidelines for ubuntu. As you can see in section "If a notification’s icon looks blurry or jagged" the code example uses the daemon name. But I don't know if there is also a flag... [1] https://wiki.ubuntu.com/NotificationDevelopmentGuidelines
The guidelines also suggests to use at least 128x128 when attaching pixmaps, but I don't think that MSN or gtalk sercers provide such a high resolution...
Is this bug still relevant with the move to gnome-shell notifications?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/94.