After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586380 - Some tags are not replaced in adium message HTML
Some tags are not replaced in adium message HTML
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Chat themes
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-19 13:11 UTC by Xavier Claessens
Modified: 2018-05-22 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Partial fix (1.69 KB, patch)
2009-06-19 13:53 UTC, Patryk Zawadzki
none Details | Review

Description Xavier Claessens 2009-06-19 13:11:49 UTC
Some tags are not replaced. If we don't have that feature we should at least fallback to an hardcoded value to avoid displaying those ugly %foo%.

%senderColor% - A color derived from the user's name. If a colon separated list of html colors is at Incoming/SenderColors.txt it will be used instead of the default colors.

%messageDirection% - The text direction of the message (either rtl or ltr) 

%textbackgroundcolor{X}% - This keyword is used to represent the highlight background color.
Comment 1 Patryk Zawadzki 2009-06-19 13:53:43 UTC
Created attachment 137005 [details] [review]
Partial fix

First part of the fix is to implement naive footer support. Most of the themes only sue Footer.html to load custom JS files so until we add header support this should be enough to make most themes happy.
Comment 2 Xavier Claessens 2009-06-19 13:59:44 UTC
Did you attach your patch to the wrong bug? I think it is for bug #586379, right?
Comment 3 Patryk Zawadzki 2009-06-19 14:01:18 UTC
Of course you are correct.
Comment 4 Olivier Le Thanh Duong 2009-06-22 01:26:37 UTC
Setting the patch as obsolete so it doesn't show in the bug list as already having a patch.
Comment 5 GNOME Infrastructure Team 2018-05-22 13:32:27 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/83.