After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582506 - Use GtkBuilder instead of libglade
Use GtkBuilder instead of libglade
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.27.x
Other Linux
: Normal normal
: 2.28.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 572883
 
 
Reported: 2009-05-13 17:38 UTC by André Klapper
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first pass (838.96 KB, patch)
2009-07-20 23:38 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review
remove check for glade in configure.in (1.01 KB, patch)
2009-07-23 01:49 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description André Klapper 2009-05-13 17:38:48 UTC
According to http://www.gnome.org/~fpeters/299.html
this module depends on libglade.

In GNOME 2.27, libglade has been deprecated in favor of GtkBuilder. See
http://library.gnome.org/devel/gtk/stable/gtk-migrating-GtkBuilder.html for
migration instructions. Also see
http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder
Comment 1 Willie Walker 2009-05-13 18:14:40 UTC
What's the time frame for when libglade will be removed?
Comment 2 André Klapper 2009-05-13 18:19:26 UTC
GNOME3 (End of March 2010) is the deadline to have it completely removed.
But this should be a small task compared to anything else.
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-07-20 23:38:05 UTC
Created attachment 138861 [details] [review]
first pass

I *think* I've gotten it all. It all *seems* to work. Put another way, it *really* needs review. ;-) Thanks!
Comment 4 Willie Walker 2009-07-21 13:08:40 UTC
(In reply to comment #3)
> Created an attachment (id=138861) [edit]
> first pass
> 
> I *think* I've gotten it all. It all *seems* to work. Put another way, it
> *really* needs review. ;-) Thanks!

It looks good to me.  In addition, it is me or does it seem as though the preferences dialog comes up quicker?  In any case, I say commit and send out a call for others to test.

Comment 5 Joanmarie Diggs (IRC: joanie) 2009-07-21 22:13:51 UTC
Thanks Will. Patch committed to master. List warned. :-)

I'm going to close this as FIXED because this bug is being used to track the progress of libglade removal by the GNOME community. If there are any regressions that resulted from this change, let's open new bugs rather than re-open this one because we are now and forever glade-free. :-)
Comment 6 Joanmarie Diggs (IRC: joanie) 2009-07-23 01:49:53 UTC
Created attachment 139045 [details] [review]
remove check for glade in configure.in

Will, in trying to figure out what might be cause the translation issues (no luck yet), I realized that we are still checking for glade in configure.in. My bad.
Comment 7 André Klapper 2009-07-23 09:48:48 UTC
(In reply to comment #6)
> Will, in trying to figure out what might be cause the translation issues

Any bug report or more info about that?
Comment 8 Joanmarie Diggs (IRC: joanie) 2009-07-23 11:11:37 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > Will, in trying to figure out what might be cause the translation issues
> 
> Any bug report or more info about that?
> 

See bug 589362 comment #20 and #21 for what Will found. Seems we're not the only ones.