GNOME Bugzilla – Bug 582311
Add hardware tab
Last modified: 2012-12-08 00:59:07 UTC
In openSUSE, we have a patch to add a hardware tab listing the hardware on the computer. Attaching the patch.
Created attachment 134491 [details] [review] openSUSE patch
Created attachment 134525 [details] [review] updated patch Very nice patch. I have updated it, completed a few more things. Comments: - filling the hardware list in a thread seems totally broken, i've disabled it - in the system info tab + /* system info */ + string bios_version; + string bios_date; + string machine_type_model; + string system_serial; + string system_board_serial; are defined but only type_model is displayed and may not be filled. What about also displaying the other fields ? - do you think libhd is portable enough, not to suse-centric ? Any chance it works on solaris, *bsd, etc ?
Hi, First, I didn't write the patch, I'm merely forwarding the work Hubert did :-) So all credit should go to him. (In reply to comment #2) > - in the system info tab > > + /* system info */ > + string bios_version; > + string bios_date; > + string machine_type_model; > + string system_serial; > + string system_board_serial; > > are defined but only type_model is displayed and may not be filled. What about > also displaying the other fields ? I've no strong opinion there, as long as the UI is fine. > - do you think libhd is portable enough, not to suse-centric ? Any chance it > works on solaris, *bsd, etc ? Hrm. I wouldn't think it's suse-centric, but if it is, it's fixable, I guess. Solaris and *BSD are unlikely to work, though :/
I was sure this was hub's work ! I'm happy with the patch but i'm concerned by the dependency, but if you think it's acceptable (do you ?), i'll push !
(In reply to comment #4) > I was sure this was hub's work ! > I'm happy with the patch but i'm concerned by the dependency, but if you think > it's acceptable (do you ?), i'll push ! Well, it needs to be proposed as an external dependency, I guess. Unless we make this code optional. I honestly can't say what is the best solution since I didn't look closely at the code and at the library :/
Pushed to 'hardware' branch http://git.gnome.org/cgit/gnome-system-monitor/commit/?h=hardware&id=1f9cab5c2eefcaaa3addcf0b9b70d2ea226fafc2
System Monitor should monitor only dynamic data, hardware information is not really dynamic, but rather static, that is why even the System tab has been removed from System monitor (see bug #649908) and it's content moved to Control Center->Details->Overview. Discussions regarding adding more hardware information are going on in control center bug #398036, so I am marking this as a duplicate of that one. Besides this, the proposed branch (quite old) uses HAL (Hardware abstraction layer) which got deprecated in the meantime, so it should not be used anymore. *** This bug has been marked as a duplicate of bug 398036 ***