Bug 577635 – crash on certain game data

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 577635 - crash on certain game data


Summary:	crash on certain game data


Status:	RESOLVED DUPLICATE of bug 516491

Product:	gnome-games-superseded
Classification:	Deprecated
Component:	gnome-sudoku
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME Games maintainers
QA Contact:	GNOME Games maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-04-01 19:01 UTC by Matthias Clasen
Modified:	2009-04-07 00:41 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
data (160.00 KB, application/x-tar) 2009-04-01 19:02 UTC, Matthias Clasen	Details

Description Matthias Clasen 2009-04-01 19:01:48 UTC

Reported here: https://bugzilla.redhat.com/show_bug.cgi?id=492962

I'll attach the problematic data.


Description of problem:
Attempting to run 'gnome-sudoku', I get:

[tbl@tlondon streamripper-1.64.5]$ gnome-sudoku 
Traceback (most recent call last):

+ Trace 214096

File "/usr/bin/gnome-sudoku", line 67 in <module>
```
start_game()
```
File "/usr/lib/python2.6/site-packages/gnome_sudoku/gnome_sudoku.py", line 22 in start_game
```
main.start_game()
```
File "/usr/lib/python2.6/site-packages/gnome_sudoku/main.py", line 970 in start_game
```
u = UI()
```
File "/usr/lib/python2.6/site-packages/gnome_sudoku/main.py", line 172 in __init__
```
if self.select_game():
```
File "/usr/lib/python2.6/site-packages/gnome_sudoku/main.py", line 65 in _
```
ret = fun(ui,*args,**kwargs)
```
File "/usr/lib/python2.6/site-packages/gnome_sudoku/main.py", line 185 in select_game
```
choice = game_selector.NewOrSavedGameSelector().run_swallowed_dialog(self.swallower)
```
File "/usr/lib/python2.6/site-packages/gnome_sudoku/game_selector.py", line 184 in run_swallowed_dialog
```
self.setup_dialog()
```
File "/usr/lib/python2.6/site-packages/gnome_sudoku/game_selector.py", line 76 in setup_dialog
```
self.make_saved_game_model()
```
File "/usr/lib/python2.6/site-packages/gnome_sudoku/game_selector.py", line 147 in make_saved_game_model
```
sudoku.sudoku_grid_from_string(g['game'].split('\n')[1].replace(' ','')).grid,
```
File "/usr/lib/python2.6/site-packages/gnome_sudoku/sudoku.py", line 229 in sudoku_grid_from_string
```
assert(len(s)<=GROUP_SIZE**2) AssertionError [tbl@tlondon streamripper-1.64.5]\$
```


Reverting to previous version (gnome-games-2.25.92-1.fc11.x86_64) does NOT fix.


Version-Release number of selected component (if applicable):
gnome-games-2.26.0-1.fc11.x86_64
gnome-games-2.25.92-1.fc11.x86_64



---

OK, that was easy.

If I delete the single file in .sudoku/saved I can start the game.

Comment 1 Matthias Clasen 2009-04-01 19:02:17 UTC

Created attachment 131861 [details]
data

Comment 2 Jesse Zhang 2009-04-02 01:53:36 UTC

This is a duplicate of Bug 516491, whose fix simply ignores malformed save files. Hopefully the origin of such problems will solved.

Comment 3 Thomas Andersen 2009-04-02 05:31:56 UTC

Yes this is a dupe of 516491. I plan to put that fix in 2.26.1 so it will be fixed there.

Matthias:
In your downstream bug you write "Built a workaround in gnome-games-2.26.0-2.fc11". Is this a copy of the fix from 516491 or did you implement something your self? (do you have a list of fedora patches available somewhere?) Either way it should be gone in 2.26.1

Comment 4 Thomas Andersen 2009-04-07 00:41:19 UTC

Fixed for 2.26.1 in bug #516491

Comment 5 Thomas Andersen 2009-04-07 00:41:54 UTC


*** This bug has been marked as a duplicate of 516491 ***