GNOME Bugzilla – Bug 574153
View/Edit Ratings from 'Now Playing' view.
Last modified: 2012-03-31 18:23:49 UTC
I'm trying hard to like the 5-star ratings system in Banshee, but I spend a lot of time with Banshee running full-screen on the Now Playing view. In this scenario, the ratings of a track don't show. and the only edit option I find is to right-click the tray icon. I would like to see/edit the ratings stars from the now playing view.
Created attachment 130046 [details] Mockup of the Now Playing view with Rating
This enhancement would be great to see! The rating would be much more useable and more easy to access.
This is a duplicate of bug 526994.
(In reply to comment #3) > This is a duplicate of bug 526994. I don't think so, the mockups of both bugs look very different :)
Sorry for the wrong word. I meant related bug. As I understood the code, a third line for the track info is needed in both cases. The track rating could be displayed in the "Now Playing" view and the track bar at the same time.
Created attachment 183650 [details] [review] Proposed patch for displaying current track's rating in the "Now Playing" view I did a small patch for displaying the rating of the current track. I formatted for git master (e19a2693). I tested it in several screen sizes and it didn't went ugly. Please feel free to test and modify it.
Review of attachment 183650 [details] [review]: Thanks for the patch ! A few additional comments : 1/ Please set a proper e-mail address in your git config, for proper attribution. 2/ I think we shouldn't display empty stars if the track is not rated. Setting the third parameter for the Render call to false should do the trick. 3/ The rating doesn't update when the track changes while I'm looking at the "Now Playing" view. 4/ In addition, it'd be really nice if the rating would fade when it changes, like the text and the cover. ::: src/Core/Banshee.ThickClient/Banshee.Gui.Widgets/LargeTrackInfoDisplay.cs @@ +108,3 @@ } + + } That change is not needed, please remove it. @@ +270,3 @@ PangoCairoHelper.ShowLayout (cr, third_line_layout); + + RatingRenderer ratingRenderer = new RatingRenderer(); That variable should be named rating_renderer See the HACKING file for code formatting guidelines
Initially I wanted to request this feature, but I wasn't aware you could right click the Banshee icon in the tray and make the rating. In that case this feature has low priority in my world.
Created attachment 210745 [details] [review] Added proposed changes to other patch. Trying to learn my way around Banshee I thought I'd give this a try. This seems to work OK, although I'd like to make the rating left aligned. There's 2 ways I'm thinking: 1) Flip the surface with the rating. (better) 2) Adjust the x coordinate depending on the number of stars. Any thoughts?
(In reply to comment #9) > There's 2 ways I'm thinking: > 1) Flip the surface with the rating. (better) > 2) Adjust the x coordinate depending on the number of stars. > > Any thoughts? Can you attach screenshots?
Created attachment 210913 [details] Screenshot with applied patch. Here's a screenshot of what it looks like now. I made a typo on my previous comment, I meant I'd like to right align it. Currently if the song is 5 stars it aligns nicely with the text, but if it's any less it's off like the SS.
Comment on attachment 183650 [details] [review] Proposed patch for displaying current track's rating in the "Now Playing" view Obsoleted by Diego's patch
Comment on attachment 210745 [details] [review] Added proposed changes to other patch. Thanks for the patch ! I committed it with a few changes: - Render the rating inside the "if (renderTrack)" block, so that it's always animated like the track title (fade in/fade out) - Don't create a new surface, just use the current Cairo Context. For that to work, I changed the RatingRender.Render method so that it doesn't modify the Context (this would mess up the rest of the rendering). http://git.gnome.org/browse/banshee/commit/?id=f17675924
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.