GNOME Bugzilla – Bug 568227
single headers
Last modified: 2009-01-25 15:09:15 UTC
IMHO the evince backend and view libraries should offer single-include headers (i.e. headers that include all other headers). (Optionally evince could enforce that ONLY this single header can be included from external code, like glib and gtk etc are moving to), but *this* bug is only about adding the single headers at all.)
Created attachment 126954 [details] [review] [PATCH] 2009-01-21 Hiroyuki Ikezoe <poincare@ikezoe.net> * shell/ev-sidebar-links.c * shell/ev-print-operation.c: * shell/ev-history.c: * shell/ev-file-monitor.c: * shell/ev-window.c: * shell/ev-password-view.c: * shell/ev-sidebar-thumbnails.c: * shell/ev-sidebar-attachments.c: * libview/ev-pixbuf-cache.c: * libview/ev-view.c: Remove needless G_OBJECT from g_signal_connect. Bug #568386. git-svn-id: svn+ssh://svn.gnome.org/svn/evince/trunk@3370 e12069bd-dc25-0410-a696-d39a8afcd844 --- ChangeLog | 14 ++++++++++++++ libview/ev-pixbuf-cache.c | 4 ++-- libview/ev-view.c | 18 +++++++++--------- shell/ev-file-monitor.c | 2 +- shell/ev-history.c | 2 +- shell/ev-password-view.c | 2 +- shell/ev-print-operation.c | 6 +++--- shell/ev-sidebar-attachments.c | 6 +++--- shell/ev-sidebar-links.c | 6 +++--- shell/ev-sidebar-thumbnails.c | 4 ++-- shell/ev-window.c | 10 +++++----- 11 files changed, 44 insertions(+), 30 deletions(-)
Created attachment 126955 [details] [review] [PATCH] Bug 568224 – library should have version macros git-svn-id: svn+ssh://svn.gnome.org/svn/evince/trunk@3371 e12069bd-dc25-0410-a696-d39a8afcd844 --- ChangeLog | 7 +++++++ configure.ac | 27 ++++++++++++++++++++++----- libdocument/Makefile.am | 5 +++-- libdocument/ev-version.h.in | 31 +++++++++++++++++++++++++++++++ 4 files changed, 63 insertions(+), 7 deletions(-)
Created attachment 126956 [details] [review] [PATCH] Bug 568220 – need pkg-config file git-svn-id: svn+ssh://svn.gnome.org/svn/evince/trunk@3372 e12069bd-dc25-0410-a696-d39a8afcd844 --- ChangeLog | 6 ++++++ Makefile.am | 5 +++++ configure.ac | 5 +++++ evince-backend.pc.in | 11 +++++++++++ evince-view.pc.in | 11 +++++++++++ 5 files changed, 38 insertions(+), 0 deletions(-)
Created attachment 126957 [details] [review] [PATCH] Bug 568229 – library needs libtool versioning git-svn-id: svn+ssh://svn.gnome.org/svn/evince/trunk@3373 e12069bd-dc25-0410-a696-d39a8afcd844 --- ChangeLog | 7 +++++++ configure.ac | 34 +++++++++++++++++++++++++++++++++- libdocument/Makefile.am | 7 ++++++- libview/Makefile.am | 15 ++++++++++----- 4 files changed, 56 insertions(+), 7 deletions(-)
Created attachment 126958 [details] [review] [PATCH] Bug 568227 – single headers Makefile.am | 3 ++ evince-backend.h | 56 ++++++++++++++++++++++++++++++++++++++++++++ evince-view.h | 32 +++++++++++++++++++++++++ help/reference/Makefile.am | 2 + libdocument/Makefile.am | 2 +- libview/Makefile.am | 4 ++- libview/ev-jobs.h | 4 +-- libview/ev-page-cache.h | 2 +- libview/ev-pixbuf-cache.h | 3 +- libview/ev-view.h | 3 +- shell/Makefile.am | 2 + 11 files changed, 103 insertions(+), 10 deletions(-)
Oops. Sorry, no idea what just happened. THe last patch is the right one.
See comment #17 on bug #568220.
Committed.