GNOME Bugzilla – Bug 567585
gstmpegtsdemux pushing newsegments in bytes as well as time format
Last modified: 2011-05-19 17:19:25 UTC
Please describe the problem: NewSegment event is just relayed as it is without being worked atall. Since newsegment is send properly through gst_fluts_demux_send_new_segment, not sure if there is any point in forwarding the GST_EVENT_NEWSEGMENT event in the gst_fluts_demux_sink_event. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 126345 [details] [review] proposed patch Proposed patch, that just consumes the newsegment event without pushing it to downstream element.
What if an upstream element sends a newsegment in GST_FORMAT_TIME ? You're not checking that the incoming newsegment event is in an invalid format.
This was fixed a long time ago: commit ff7b54e7da95a401665f8d7ae922155a32edac91 Author: Zaheer Merali <zaheerabbas@merali.org> Date: Fri May 8 18:24:28 2009 +0100 mpegtsdemux: Add initial naive seeking support and fix duration query. Sync from gst-fluendo-mpegdemux and have seeking/duration query improvements in. No support however for wrapped around pcrs etc. but a start nonetheless. Also fix indentation issues.