GNOME Bugzilla – Bug 560583
Use disc number in filenames when it makes sense
Last modified: 2009-01-13 19:07:52 UTC
I've taken to not using the "Album Title (disc 1)" approach to multi-disc albums. Instead, I just use the album title and set the disc number. Then I just get one entry for the album in the listing, and Banshee correctly sorts the tracks, taking the disc number into account. The downside is the the files no longer sort nicely in Nautilus. And I'm just waiting for the day that two discs of a single album have the same title for the same track number. When the total number of discs is greater than one, Banshee should use something like "discnum-tracknum" for the Number component of the file name.
Created attachment 124230 [details] [review] patch to implement desired behavior Adding DiscCount and DiscNumber to ITrackInfo might be the wrong way, if there's some implementation other than TrackInfo that doesn't provide these. I suppose one could probably check if t is a TrackInfo and cast (?) it. This is the extent of what I could do without pulling out a C# reference.
This feature would also be provided by the patch in bug #563403, which adds other tokens beside disc number.
Hmm, if I were to use %disc_number% from your proposal in comment #2 of that bug to effect what my (admittedly simpler and less flexible) patch does, I would do this: "%disc_number%-%track_number%...". Correct? But if %disc_number% is empty for one-disc albums, I'd end up with filenames that start with "-", which is pretty sucky to deal with on the command line. I'm all for more flexible solutions, but I'd like to be sure I can accomplish the pretty basic thing I've done easily.
Shaun, I totally agree, but let's consolidate this with the other bug. We need a big revamp of this that allows a lot more flexibility, and accounts for complications like your multi-disc patch, and compilation albums, etc. *** This bug has been marked as a duplicate of 563403 ***