GNOME Bugzilla – Bug 559990
Add UI for the cursor blink preference
Last modified: 2017-12-31 16:28:12 UTC
Please describe the problem: There should be a dropdown for the gnome-terminal cursor blink preference: * Follow system default (on/off) * On * Off Currently, this functionality can only be accessed by the following gconf keys: /apps/gnome-terminal/profiles/Default/cursor_blink_mode /apps/gnome-terminal/profiles/Default/cursor_blink Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information: The UI for blinking cursor has been removed in bug 342921; later, during the discussion in the bug it has been agreed, that having UI like this is desired. Bug 533522 has been created for it, but later hijacked for just a part of this functionality (a gconf setting). Creating this one to track the status originally suggested in bug 533522.
(In reply to comment #0) > Currently, this functionality can only be accessed by the following gconf keys: > > /apps/gnome-terminal/profiles/Default/cursor_blink_mode > /apps/gnome-terminal/profiles/Default/cursor_blink Actually it's just the first gconf key; the 2nd one was the old pref and isn't supported anymore.
Created attachment 130577 [details] [review] Adds a ComboBox in the profile preference dialog to set the cursor blink mode
The patch itself in attachment 130577 [details] [review] is fine. I'm undecided yet if I want to have this feature, though.
Created attachment 186072 [details] [review] Allow cursor-blink-mode to be modified via profile settings I tested the patch above, but it didn't work for me. After a slight modification, I came up with a new patch that works. See also, the downstream bug in Launchpad: https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/762399
*** Bug 682895 has been marked as a duplicate of this bug. ***
Why do I have to google to find a way to disable cursor blinking, why is there no UI in the Preference for this? I can configure background, color, font family, font size in the UI, but the annoying cursor blinking I can't?
Created attachment 366056 [details] [review] Fix Yup, let's do this!
Comment on attachment 366056 [details] [review] Fix Ok.
I don't quite like the wording, though. Especially "System" looks stupid to me. Should it be perhaps "Follow system default" (as per the original bugreport) or "System default", "GNOME default", "Default", ...? Also instead of "On"/"Off", "Enabled"/"Disabled" sounds better to me. Opinions?
The theme variant combobox in general prefs uses "Default", so this should use the same (or if we go with something else here, that should also be changed). And agreed that En/Disabled sounds better than the short On/Off.
Perfect, I'll go with "Default", "En/Disabled". I'll submit when we finalize the cell-spacing UI, to avoid conflicts.
Submitted.