GNOME Bugzilla – Bug 549693
ORBit2 might enter an infinite make loop when used on parallel make
Last modified: 2008-09-08 17:27:41 UTC
Please describe the problem: When building iwth parallel make (make -jN with N > 1), the build might get stuck in an infinite loop. The reason for this is that the .PHONY directive tells make that a given rule has _always_ to be rebuilt, so it will be stuck in calling the make for idl-compiler. The attached patch sanitises the build a bit by removing the phony rule, and making the rule look "real" to make. It also removes the "true" calls, as it's just declaring dependencies for the .c file rather than having a rule generate it. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 117514 [details] [review] Patch to fix.
looks fine to commit to me. Of course, the IDL compilation itself is horrible in ORBit2 - just running 'make' will re-build the IDL and hence a chunk of the code itself - some broken Makefile rules from the past. It'd be great to fix that too, if you're passing :-)
I commited this. If you want to look at the other issues there's a patch in bug 319379.
Closing as well.