GNOME Bugzilla – Bug 547661
vcd: port to 1.0
Last modified: 2018-11-03 13:03:28 UTC
I should have logged this bug long time ago. But I didn't keep an eye on release schedule. Now the VCD plugin works properly and plays any track with command 'gst-launch-0.10 playbin uri=vcd://n', it will be nice if seek support is added so that VCD can be played from totem with seek, track changes etc.
VCDs just play the first track and stop. Please help to fix it.
Let's re-purpose this bug as a port-to-1.0 enhancement bug, and hopefully whoever ports it can also take care of the seeking then. Other vcd issues: bug #325441 (vcdsrc doesn't handle CUE/BIN images) and bug #733794 (Error trying to play a VCD from a CDR).
*** Bug 733794 has been marked as a duplicate of this bug. ***
*** Bug 325441 has been marked as a duplicate of this bug. ***
I will take care of this one.
Created attachment 291951 [details] [review] vcdsrc: port to 1. API only port to 1. Untested
Review of attachment 291951 [details] [review]: Looks almost ready, good work :) ::: sys/vcd/vcdsrc.c @@ +356,3 @@ +error_mapped: + gst_buffer_unmap (outbuf, &map_info); +error_unmapped: You should also unref outbuf here @@ +476,1 @@ gst_vcdsrc_uri_get_uri (GstURIHandler * handler) This change probably means that you need to g_strdup() the URI you return
Thanks for taking a look Sebastian (In reply to comment #7) > Review of attachment 291951 [details] [review]: > [...] > ::: sys/vcd/vcdsrc.c > @@ +356,3 @@ > +error_mapped: > + gst_buffer_unmap (outbuf, &map_info); > +error_unmapped: > > You should also unref outbuf here Done > @@ +476,1 @@ > gst_vcdsrc_uri_get_uri (GstURIHandler * handler) > > This change probably means that you need to g_strdup() the URI you return Not sure I understand. I'm already duping that return
Created attachment 292137 [details] [review] vcdsrc: port to 1. unref buffer at failure
(In reply to comment #8) > > @@ +476,1 @@ > > gst_vcdsrc_uri_get_uri (GstURIHandler * handler) > > > > This change probably means that you need to g_strdup() the URI you return > > Not sure I understand. I'm already duping that return I see, then this code was leaking in 0.10 ;)
Comment on attachment 292137 [details] [review] vcdsrc: port to 1. Not closing the bug yet as there are related and pending enhancements requested but pushed the port to 1.0 to get this started. Thanks again for the review. commit 89eb1e9a038d21ca468b357905b35bf6a38ed0be Author: Reynaldo H. Verdejo Pinochet <reynaldo@osg.samsung.com> Date: Mon Dec 1 16:40:24 2014 -0300 vcdsrc: port to 1.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/5.