GNOME Bugzilla – Bug 516844
Build fix + drop gnome-vfs dependency
Last modified: 2008-10-18 08:01:34 UTC
After the change in epiphany.pc, epiphany-extensions do not build anymore. Also, ephy-file-helpers.h has changed with the gio transition and some extensions which made use of that do no longer build. I made a patch to drop gnome-vfs dependency and fix these build issues.
Created attachment 105378 [details] [review] patch
Created attachment 105379 [details] [review] patch v2 Oops, I left a snippet from another unrelated patch in there.
*** Bug 516954 has been marked as a duplicate of this bug. ***
Looks good; thanks! It seems the adblock filter rules are loaded sync, in the UI thread? If so, maybe we should have a follow-up to use async loading there, so as to not block the UI.
Committed to trunk. ------------------------------------------------------------------------ r1672 | cosimoc | 2008-02-18 20:08:12 +0100 (lun, 18 feb 2008) | 3 lines Drop gnome-vfs dependency and fix the build. Bug #516844.
The favicon (Python) extension still imports and uses GnomeVFS. I suggest replacing the use of GnomeVFS in this extension with the standard Python urlparse[1] module: uriparts = urlparse.urlsplit(embed.get_property('address')) single = epiphany.ephy_shell_get_default().get_embed_single() backend = single.get_backend_name(); if uriparts[0] == "http" or (uriparts[0] == "https" and backend != "gecko-1.7") : url = urlparse.urlunsplit(uriparts[:2] + ("/favicon.ico", "", "")) embed.set_property('icon_address', url) The code piece above is not tested (I only have GNOME 2.20 installed). [1]: http://docs.python.org/lib/module-urlparse.html
reopen as per last comment.
any news? 2.23.91 tarballs due is on this monday.
*ping* Hardcode Freeze on next Monday!
(In reply to comment #9) > *ping* > Hardcode Freeze on next Monday! Not for e-e since it's not in any gnome release suite :)
Ok, so there's no need to set the gnome target, right? :)
Right.
I'll commit something in a while.
Created attachment 118379 [details] [review] [PATCH] Remove gnomevfs dep from favicon extension Remove the gnomevfs dependency of favicon.py and pythonify the source. gnomevfs was replaced with urlparse, patch by Stefan Stuhr, closes: 516844 --- extensions/favicon/favicon.py | 43 +++++++++++++++++++++------------------- 1 files changed, 23 insertions(+), 20 deletions(-)
Committed to trunk and gnome-2-24. Page info still uses gnome_vfs!
Cosimo already removed it by commenting the parts that were old galeon stuff anyway, closing as fixed.