After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 515240 - Draw subtitles after scaling video
Draw subtitles after scaling video
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: GStreamer backend
2.22.x
Other All
: Normal minor
: ---
Assigned To: Maintainer alias for GStreamer component of Totem
Maintainer alias for GStreamer component of Totem
: 370733 622444 736001 (view as bug list)
Depends on: 721925 731848
Blocks:
 
 
Reported: 2008-02-08 17:37 UTC by jvalente
Modified: 2014-12-07 17:56 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
screenshot of the problem (277.01 KB, image/png)
2008-03-26 16:34 UTC, Teppo Turtiainen
Details
default aspect ratio 2.35:1 (190.83 KB, image/png)
2011-07-15 16:10 UTC, zebul666
Details
aspect ratio 16/9 (155.70 KB, image/png)
2011-07-15 16:11 UTC, zebul666
Details
aspect ratio 4:3 (123.34 KB, image/png)
2011-07-15 16:12 UTC, zebul666
Details

Description jvalente 2008-02-08 17:37:03 UTC
Please describe the problem:
The video subtitles are very pixelized.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?
Yes

Other information:
This not deppends on font type and neither on its size
Comment 1 Baptiste Mille-Mathias 2008-02-08 17:39:45 UTC
Hello,

Could you elaborate a little more and add a screenshot of the problem please ?
Comment 2 Bastien Nocera 2008-02-08 17:58:11 UTC
And tell us which backend you use as well, and a way to reproduce the problem.
Comment 3 Teppo Turtiainen 2008-03-26 16:32:15 UTC
This happens at least with the gstreamer backend (I haven't tried with the xine backend). The problem is easy to see if you use a really large subtitle font. Please see attached screenshot.
Comment 4 Teppo Turtiainen 2008-03-26 16:34:51 UTC
Created attachment 108071 [details]
screenshot of the problem
Comment 5 Bastien Nocera 2008-03-26 18:03:02 UTC
What's the resolution of the video? Does it happen with another (larger) video?

I'm guessing it would be because the subtitles are blended into the video, and then scaled, rather than being added after the scaling (which is usually done by the Xv adapter).
Comment 6 Teppo Turtiainen 2008-03-26 18:22:49 UTC
(In reply to comment #5)
> What's the resolution of the video? Does it happen with another (larger) video?

The resolution of the video where the screenshot is from is 800 x 336. I don't have video with higher resolution at hand.

> I'm guessing it would be because the subtitles are blended into the video, and
> then scaled, rather than being added after the scaling (which is usually done
> by the Xv adapter).

Would it be possible to add the subtitles after scaling the video?
Comment 7 Bastien Nocera 2008-03-26 18:49:45 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > What's the resolution of the video? Does it happen with another (larger) video?
> 
> The resolution of the video where the screenshot is from is 800 x 336. I don't
> have video with higher resolution at hand.

There's HD trailers to download on the internet...

> > I'm guessing it would be because the subtitles are blended into the video, and
> > then scaled, rather than being added after the scaling (which is usually done
> > by the Xv adapter).
> 
> Would it be possible to add the subtitles after scaling the video?

The hardware does the scaling, so it would need to be done in a completely different way.
Comment 8 Teppo Turtiainen 2008-03-26 19:13:19 UTC
(In reply to comment #7)
> There's HD trailers to download on the internet...

My computer can't manage those. Someone else will have to test that.
Comment 9 Bastien Nocera 2010-05-06 13:46:46 UTC
Moving that to GStreamer, as Totem doesn't do the subtitle rendering anyway.

The drawing of the subtitles is currently done before passing the video to the video sink, in the original size. Instead, the overlay should be drawn after the video has been scaled, but before it is displayed.
Comment 10 Bastien Nocera 2010-06-22 23:03:28 UTC
*** Bug 622444 has been marked as a duplicate of this bug. ***
Comment 11 zebul666 2011-07-15 15:34:59 UTC
I don't open a new bug report, but when viewing a video, and changing aspect ratio of the video, the subtitles (LOADED from an SRT file) also change of aspect ratio which is rather a bad behavior to my point of view.

joined screenshots to illustrate
Comment 12 zebul666 2011-07-15 16:10:04 UTC
well is it another bug ?
when I take screenshot with totem, it does not take into account the aspect ratio I have chosen.

So I had to use a screenshot utility to show you what I want... sight
Comment 13 zebul666 2011-07-15 16:10:50 UTC
Created attachment 192035 [details]
default aspect ratio 2.35:1
Comment 14 zebul666 2011-07-15 16:11:29 UTC
Created attachment 192036 [details]
aspect ratio 16/9
Comment 15 zebul666 2011-07-15 16:12:04 UTC
Created attachment 192037 [details]
aspect ratio 4:3
Comment 16 Tim-Philipp Müller 2011-07-15 16:21:38 UTC
I think textoverlay not taking into account the aspect-ratio is a separate bug in its own right, even if a solution for this bug would probably fix that issue as well.
Comment 17 Bastien Nocera 2012-03-29 12:53:12 UTC
*** Bug 370733 has been marked as a duplicate of this bug. ***
Comment 18 Bastien Nocera 2014-09-04 01:31:39 UTC
*** Bug 736001 has been marked as a duplicate of this bug. ***
Comment 19 Bastien Nocera 2014-12-07 17:56:14 UTC
Will be fixed in GNOME 3.16 with the new clutter-gst support. See bug 731848 for details.