GNOME Bugzilla – Bug 512303
(ff3) table captions are not being presented
Last modified: 2008-07-22 19:33:35 UTC
Please describe the problem: Please see attached example. I can just about see that the caption is being displayed (sorry sight is v poor) but orca isnt announcing it. Obviously this is a contrived example, but there are tables out there with useful captions. Steps to reproduce: Actual results: Expected results: Does this happen every time? yes Other information:
Created attachment 103790 [details] caption_testcase
*** Bug 512309 has been marked as a duplicate of this bug. ***
Created attachment 103797 [details] [review] revision 1 Please test. Thanks!
Thanks Joanie, now we are hearing: <captiontext> caption and on the braille display: <captiontext> maybe we should indicate that it is a table caption in the braille too? Thanks PS. sorry for dubble bugging, i wasnt sure if the two were related or not.
Thanks for testing Jon! > maybe we should indicate that it is a table caption in the braille too? Sounds good to me. But I defer to our UI guy on such matters. Mike, thoughts? If we agree that this should be done, I'll open a new bug for it as I suspect it will be an Orca-wide braille generator change (as opposed to a Gecko.py change). > PS. sorry for dubble bugging, i wasnt sure if the two were related or not. Hey, no problem. To be perfectly honest, I didn't know if they were related or not until I fixed this one and the other one went away. <smile> Gosh I like it when that happens.... A lot.... Besides, I'm starting to agree with Rich that one bug per issue is far preferable to a large uber bug. In that spirit, does the patch fix your reported bug? <smile>
indeed it fixes the reported bug. :) I'll lookout for the corresponding braille bug. Thank you for the good work.
Created attachment 103845 [details] [review] revision 2 Heh. Turned out it was a Gecko.py thing. When arrowing around in a document, we typically don't tack on rolenames in the braille. We have special handling for headings and links. This patch adds special handling for captions. Please test.
excellent. Both abbriviated and non-abbriviated braille are working fine. you truely squashed this one :)
This is great. It will be interesting to see how many sites have these captions that I never noticed.
Thanks guys. Patch committed. Moving to pending.