After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511118 - We sometimes get stuck on images that are also links
We sometimes get stuck on images that are also links
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other All
: Normal normal
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-01-21 20:31 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
aforementioned test case (402 bytes, text/html)
2008-01-21 20:32 UTC, Joanmarie Diggs (IRC: joanie) 		  Details
revision 1 (1.14 KB, patch)
2008-01-21 21:43 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-01-21 20:31:34 UTC 
Steps to reproduce:

1. View the test case (to be attached).
2. Down arrow from the top of the page to the bottom.

Expected results: You'd be able to.

Actual results:  We get stuck on the images that are also links.

Note: This problem occurs even with "pre-performance-enhancement Orca."
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-01-21 20:32:16 UTC 
Created attachment 103364 [details]
aforementioned test case
Comment 2 Joanmarie Diggs (IRC: joanie) 2008-01-21 21:43:01 UTC 
Created attachment 103370 [details] [review]
revision 1

This *seems* to work.  I'm about to run regression tests now. <smile>
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-01-21 23:01:35 UTC 
Okay, it seems to pass the pylint and regression test tests. :-)  Question is:  Is it the right thing to do?  Will, if you wouldn't mind taking a look.  Thanks!
Comment 4 Willie Walker 2008-01-22 14:40:43 UTC 
(In reply to comment #3)
> Okay, it seems to pass the pylint and regression test tests. :-)  Question is: 
> Is it the right thing to do?  Will, if you wouldn't mind taking a look. 
> Thanks!
> 

I think it looks good.  But, then again, your knowledge of the details of Gecko.py is exceeding mine at this point.
Comment 5 Joanmarie Diggs (IRC: joanie) 2008-01-22 14:53:41 UTC 
Thanks Will. Mike and/or Jon, please test the patch.
Comment 6 Mesar Hameed 2008-01-22 19:38:43 UTC 
works fine, will look around for more examples though.
Comment 7 Mike Pedersen 2008-01-22 19:56:18 UTC 
This one looks good to me as well.
Comment 8 Joanmarie Diggs (IRC: joanie) 2008-01-22 20:04:44 UTC 
Thanks guys!  Based on your feedback, I went ahead and committed the patch and am moving this to pending.
Comment 9 Mesar Hameed 2008-01-22 20:16:15 UTC 
Joanie, got another one for you, but probably not part of this particular bug, closely related though.
bug 511354
Comment 10 Mike Pedersen 2008-01-24 20:36:30 UTC 
I'm going to verify this one because it fixes the origional problem.
Comment 11 Joanmarie Diggs (IRC: joanie) 2008-01-24 20:43:11 UTC 
Thanks Mike.  Closing as FIXED.