After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509940 - Port to GIO
Port to GIO
Status: RESOLVED FIXED
Product: seahorse-plugins
Classification: Applications
Component: Nautilus
2.23.x
Other Linux
: Normal normal
: 2.24
Assigned To: seahorse-plugins-maint
seahorse-plugins-maint
Depends on: 505990
Blocks:
 
 
Reported: 2008-01-16 17:09 UTC by Joseph Sacco
Modified: 2008-06-30 21:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22



Description Joseph Sacco 2008-01-16 17:09:29 UTC
plugins/nautilus-ext does not compile because of an include path problem.

A proposed fix is shown below.

-Joseph

====================problem ============================================
seahorse-nautilus.c:27:41: error: libgnomevfs/gnome-vfs-utils.h: No such file or directory
seahorse-nautilus.c:28:45: error: libgnomevfs/gnome-vfs-file-info.h: No such file or directory
seahorse-nautilus.c:29:39: error: libgnomevfs/gnome-vfs-ops.h: No such file or directory
make[4]: *** [seahorse-nautilus.lo] Error 1
make[4]: Leaving directory `/usr/local/src/GARNOME/Devel/garnome-trunk/src/desktop/seahorse/work/main.d/seahorse-2.21.4/plugins/nautilus-ext'
make[3]: *** [all-recursive] Error 1


=====================proposed fix =============================================

--- seahorse-2.21.4/plugins/nautilus-ext/Makefile.in-   2008-01-16 12:02:30.000000000 -0500
+++ seahorse-2.21.4/plugins/nautilus-ext/Makefile.in    2008-01-16 12:03:04.000000000 -0500
@@ -290,6 +290,7 @@
 INCLUDES = -I$(top_builddir)   \
    -I$(top_srcdir)             \
    $(NAUTILUS_CFLAGS)          \
+   $(SEAHORSE_CFLAGS)          \
    -DGNOMELOCALEDIR=\""$(datadir)/locale"\"
Comment 1 Joseph Sacco 2008-01-16 18:37:45 UTC
It might be better to resolve this problem in nautilus.  See

     http://bugzilla.gnome.org/show_bug.cgi?id=509966


-Joseph
Comment 2 Stef Walter 2008-01-16 19:19:00 UTC
A fix for this already exists in seahorse however bug #505990 is blocking the next release of seahorse. 
Comment 3 Olav Vitters 2008-01-16 21:02:21 UTC
Note: Nautilus uses gvfs, not gnome-vfs. That won't change. So seahorse needs to be fixed asap. I'll ping again for the autofoo stuff.
Comment 4 Joseph Sacco 2008-01-16 21:24:53 UTC
OK... "We" should also ping the folks maintaining file-roller since they have the same problem.

-Joseph
Comment 5 André Klapper 2008-06-05 14:58:11 UTC
file-roller has been fixed already, see bug 501542.
any news?
Comment 6 André Klapper 2008-06-22 16:21:18 UTC
stef: ping
Comment 7 Adam Schreiber 2008-06-22 20:36:10 UTC
seahorse has already been ported.

compnerd in #gnome-hackers was working on porting seahorse-plugins.
Comment 8 Stef Walter 2008-06-30 21:50:04 UTC
Completed. Testing by anyone interested, would be appreciated to make sure things work in all cases.

2008-06-30  Stef Walter  <stef@memberwebs.com>

	* configure.in:
	* libseahorse/Makefile.am:
	* libseahorse/seahorse-gtkstock.h:
	* libseahorse/seahorse-multi-encrypt.glade: (added back)
	* libseahorse/seahorse-util.c:
	* libseahorse/seahorse-util.h:
	* libseahorse/seahorse-vfs-data.c:
	* libseahorse/seahorse-vfs-data.h:
	* plugins/applet/seahorse-applet.c:
	* plugins/nautilus/seahorse-tool.c:
	* plugins/nautilus/seahorse-tool-files.c:
	* plugins/nautilus/seahorse-tool-progress.c:
	* plugins/nautilus-ext/seahorse-nautilus.c: Port to GIO from gnome-vfs
	Fixes bug #509940