After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509482 - Line navigation in FF wraps from top of file to bottom.
Line navigation in FF wraps from top of file to bottom.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other All
: Normal normal
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-01-14 21:01 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
revision 1 (1.91 KB, patch)
2008-01-14 21:12 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-01-14 21:01:28 UTC
From Jon on the Orca list:

> [...]
> One little bug though, which is when arriving at top of page, pressing 
> up arrow again cycles down to the bottom of page.
> 
> When at bottom of page, pressing down arrow again doesnt cycle up to the 
> top.

Thanks Jon for the report!  Patch to follow
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-01-14 21:12:16 UTC
Created attachment 102855 [details] [review]
revision 1

This bug is an illustration of why friends shouldn't let friends code when they're tired. <smile>

Mike and Jon, please test.  Thanks!
Comment 2 Mesar Hameed 2008-01-14 21:36:38 UTC
that seems to have fixed it, Thanks Joanie!
Comment 3 Mike Pedersen 2008-01-15 01:36:45 UTC
Looks good to me as well.  
Comment 4 Mesar Hameed 2008-01-15 10:56:13 UTC
Sorry, maybe it should come under a diffrent bug, but here it is for now:
arrowing right beyond the last line of webpage  cycles up to start.
at start arrowing left does not take the user to bottom.

Comment 5 Joanmarie Diggs (IRC: joanie) 2008-01-18 21:05:26 UTC
Because the above patch just makes changes to our new/alternative line navigation (still in a state of flux), because it pylints to a 10.0, and because it does not introduce any regressions based on regression testing, I've gone ahead and committed it and am moving this bug to pending.

Jon, thanks so much for your testing!  It turns out that the issue you reported in comment #4 is indeed a different one and has likely been around for quite some time but not noticed. :-(  Therefore I opened a bug #510478 for it.  After I get the line navigation more solid, I'll tackle it.  Thanks again!!
Comment 6 Joanmarie Diggs (IRC: joanie) 2008-01-22 21:23:59 UTC
It was determined in team meeting to close this is FIXED.