GNOME Bugzilla – Bug 501617
gtk+ 2.12.13 tarball broken
Last modified: 2008-02-10 03:19:52 UTC
The reason is this check in gtk-doc.make: if test "`which gtkdoc-rebase`" != ""; then \ gtkdoc-rebase ... With my version of which (and no gtk-doc installed), this evaluates to if test "which: no gtkdoc-rebase in (/usr/local/bin:/usr/bin:/usr/X11R6/bin:/bin:/opt/gnome2/bin:/opt/gnome/bin)" != ""; then ... Eek. Fix against trunk attached.
Created attachment 100208 [details] [review] fix check for gtkdoc-rebase
Created attachment 100210 [details] [review] fix check for gtkdoc-rebase, silent I guess we don't need the noise...
This is fixed in svn already. *** This bug has been marked as a duplicate of 501066 ***
Short: not a duplicate, re-open Long: The command which has several versions. One version is "silent", has no output when parameterprogram wasn't found. Other version are "loud" and yield "which: parameterprogram not found" The patch in attachment id=100210 with which parameterprogramm && parameterprogram parameterprogramownparameters handles "silent" and "loud" versions of 'which' Please re-open this bugreport and apply the provided patch.
Better fix for Bug 501066 committed. Its still a dup (the other report is older, but this fix seems to be better). *** This bug has been marked as a duplicate of 501066 ***
I still don't see how this is a dupe (it fixes a problem that has nothing to do with bug 501066), but whatever...
Jens, thanks for the better patch, but basically the way it was checked for 'gtkdoc-rebase' was broken.
This method of testing for gtkdoc-rebase causes make to die with an error for me when building libwnck when I don't have gtk-doc installed. The test method in #501066 works for me, if the issue here was primarily the noise factor then ">/dev/null" can be added inside the quotes of the test method. For reference see libwnck bug #511414.
Yes, the test was still flawed, no, noise was not the issue, current svn has a working fix now.
If by current svn you mean revision 542 of gtk-doc.make on svn.gnome.org then no it doesn't have a working fix, that's what I was saying. The 'which gtkdoc-rebase >/dev/null && ...' test causes make to die when I run make install. I will attach the log from make install in a moment. I believe it is the which gtkdoc-rebase line is failing because the install line immediately before it (which installs index.sgml) works correctly. deryni@raguel:~$ ls /tmp/foobar/share/gtk-doc/html/libwnck/index* /tmp/foobar/share/gtk-doc/html/libwnck/index.html /tmp/foobar/share/gtk-doc/html/libwnck/index.sgml /tmp/foobar/share/gtk-doc/html/libwnck/indexes.html For the record, the which I am using is coming from the debianutils package version 2.28.3 .
Ah, my apologies, it would appear that it does in fact work and that I just failed to copy it in correctly when I was testing it. I'm used to projects which re-generate the .in files as needed, libwnck appears not to. Sorry for the noise. =)