GNOME Bugzilla – Bug 494203
when importing images that have import problems (such as missing or corrupt headers) a dialog box pops up with either cancel or skip
Last modified: 2008-03-14 09:59:01 UTC
The dialog box should have a "skip all" button in case there are a lot of import errors so that the user doesn't have to baby sit the importing process. If there is even one corrupt photo it stops the entire process of importing images and waits for the user to confirm. Instead the program should either skip the errors and report them after importing all the good the images into the database or it should have a "skip all" button so that after the first error the program knows to skip all images like this from then on. Other information:
Created attachment 98694 [details] [review] skipall-on-folder-import.patch this small patch implements the skip all button.
Thanks for the help. It was really quick! But... I'm a terrible newb... where do I put this code?
Follow this instructions to get and compile the latest SVN version. http://f-spot.org/How_To_Build_from_HEAD Before issuing "make", follow instructions at the bottom of that page to install this patch. This way you can test the patch. I don't know if it will ever be part of a release, because 1. the import stuff is being redesigned, and 2. we will have to see what devs will think about it :-) ciao
Resources: maxxer @ irc://irc.gnome.org/#f-spot http://bugzilla.gnome.org/show_bug.cgi?id=494203 http://bugzilla.gnome.org/attachment.cgi?id=98694 http://www.koders.com/csharp/fid88F5ACC58536B18DE01903742155D468CBD7ECFA.aspx http://f-spot.org/How_To_Build_from_Release http://f-spot.org/How_To_Build_from_HEAD http://f-spot.org/Get_Involved_FAQ First I removed the old Installation (compiled from source!!!): manfred@icebreaker:~/Desktop/f-spot-0.4.0$ su Password: icebreaker:/home/manfred/Desktop/f-spot-0.4.0# make uninstall and logged out from root's account: icebreaker:/home/manfred/Desktop/f-spot-0.4.0# exit exit I downloaded "skipall-on-folder-import.patch" from http://bugzilla.gnome.org/attachment.cgi?id=98694 and copied it to ~/Desktop/f-spot-0.4.0/src manfred@icebreaker:~/Desktop/f-spot-0.4.0$ cd src Then I ran manfred@icebreaker:~/Desktop/f-spot-0.4.0/src$ patch -p0 < skipall-on-folder-import.patch can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: src/FileImportBackend.cs |=================================================================== |--- src/FileImportBackend.cs (revisione 3456) |+++ src/FileImportBackend.cs (copia locale) -------------------------- File to patch: FileImportBackend.cs patching file FileImportBackend.cs manfred@icebreaker:~/Desktop/f-spot-0.4.0/src$ And reconfigured / -compiled / -installed F-Spot: manfred@icebreaker:~/Desktop/f-spot-0.4.0/src$ cd .. manfred@icebreaker:~/Desktop/f-spot-0.4.0$ ./configure > fspot_configure_output.txt manfred@icebreaker:~/Desktop/f-spot-0.4.0$ make > fspot_make_output.txt the following warnings were printed to stderr: ./Core.cs(68,21): warning CS0219: The variable `nameReply' is assigned but its value is never used ./Editors/SoftFocus.cs(101,23): warning CS0219: The variable `result' is assigned but its value is never used ./PhotoStore.cs(1190,26): warning CS0618: `PhotoStore.AddLastImportFilter(FSpot.RollSet, bool)' is obsolete: `drop this, use IQueryCondition correctly instead' ./PhotoStore.cs(1247,26): warning CS0618: `PhotoStore.AddLastImportFilter(FSpot.RollSet, bool)' is obsolete: `drop this, use IQueryCondition correctly instead' ./Widgets/FindBar.cs(303,21): warning CS0219: The variable `term' is assigned but its value is never used ./XmpTagsImporter.cs(154,19): warning CS0219: The variable `list' is assigned but its value is never used manfred@icebreaker:~/Desktop/f-spot-0.4.0$ su Password: icebreaker:/home/manfred/Desktop/f-spot-0.4.0# make install > fspot_make_install_output.txt the following warnings were printed to stderr: Cache file created successfully. libtool: install: warning: relinking `libfspot.la' libtool: link: warning: `/usr/lib/gcc/i486-linux-gnu/4.1.2/../../..//libjpeg.la' seems to be moved libtool: link: warning: `/usr/lib/gcc/i486-linux-gnu/4.1.2/../../..//libjpeg.la' seems to be moved well,... something went wrong... asked for it on irc... there I got make clean and make install as solution...: icebreaker:/home/manfred/Desktop/f-spot-0.4.0# make clean > fspot_make_clean_output.txt icebreaker:/home/manfred/Desktop/f-spot-0.4.0# make install > fspot_make_install_output_2.txt and got the following errors: ./Address.cs(28,4): warning CS0278: `System.Collections.Generic.IDictionary<string,string>' contains ambiguous implementation of `enumerable' pattern. Method `System.Collections.IEnumerable.GetEnumerator()' is ambiguous with method `System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string,string>>.GetEnumerator()' /usr/lib/mono/2.0/mscorlib.dll (Location of the symbol related to previous warning) /usr/lib/mono/2.0/mscorlib.dll (Location of the symbol related to previous warning) /usr/bin/install: Aufruf von stat für „./da/f-spot.xml“ nicht möglich: Datei oder Verzeichnis nicht gefunden /usr/bin/install: Aufruf von stat für „./es/f-spot.xml“ nicht möglich: Datei oder Verzeichnis nicht gefunden /usr/bin/install: Aufruf von stat für „./fr/f-spot.xml“ nicht möglich: Datei oder Verzeichnis nicht gefunden /usr/bin/install: Aufruf von stat für „./it/f-spot.xml“ nicht möglich: Datei oder Verzeichnis nicht gefunden /usr/bin/install: Aufruf von stat für „./pt_BR/f-spot.xml“ nicht möglich: Datei oder Verzeichnis nicht gefunden /usr/bin/install: Aufruf von stat für „./sv/f-spot.xml“ nicht möglich: Datei oder Verzeichnis nicht gefunden make[2]: *** [install-doc-docs] Fehler 1 make[1]: *** [install-am] Fehler 2 make: *** [install-recursive] Fehler 1 and finally logged out from root's account: icebreaker:/home/manfred/Desktop/f-spot-0.4.0# exit exit manfred@icebreaker:~/Desktop/f-spot-0.4.0$ but it seems to work fine now...
Created attachment 99073 [details] shows what I have done to apply the patch: find in which source file the error messages are created shows what I have done to apply the patch: find in which source file the error messages are created
Created attachment 99074 [details] shows what I have done to apply the patch: find in which source file the error messages are created shows what I have done to apply the patch: find in which source file the error messages are created
Created attachment 99075 [details] shows what I have done to apply the patch: step - by -step shows what I have done to apply the patch: step - by -step
Created attachment 99076 [details] shows what I have done to apply the patch: output of make uninstall shows what I have done to apply the patch: output of make uninstall
Created attachment 99077 [details] shows what I have done to apply the patch: output of configure shows what I have done to apply the patch: output of configure
Created attachment 99078 [details] shows what I have done to apply the patch: output of make shows what I have done to apply the patch: output of make
Created attachment 99079 [details] shows what I have done to apply the patch: output of make install shows what I have done to apply the patch: output of make install
Created attachment 99080 [details] shows what I have done to apply the patch: output of make clean shows what I have done to apply the patch: output of make clean
Created attachment 99081 [details] shows what I have done to apply the patch: output of make install (2) shows what I have done to apply the patch: output of make install (2nd try)
(In reply to comment #4) These errors are not related to this bug nor to this patch, you shouldn't have posted them here but on irc again or on the mailing list! > manfred@icebreaker:~/Desktop/f-spot-0.4.0/src$ patch -p0 < > skipall-on-folder-import.patch > can't find file to patch at input line 5 patches must be applied to f-spot root, not in src/. I still believe restarting from scratch would help. Please discuss any further build error on irc or on the mailing list.
*** This bug has been marked as a duplicate of 480861 ***