After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 461816 - Wrong punctuation on a check box and on the frame titles
Wrong punctuation on a check box and on the frame titles
Status: RESOLVED FIXED
Product: dasher
Classification: Applications
Component: general
4.5.x
Other All
: Normal trivial
: ---
Assigned To: Aaron Larson
Phil Cowans
: 461815 (view as bug list)
Depends on: 506900
Blocks:
 
 
Reported: 2007-07-30 14:25 UTC by Stephane Raimbault
Modified: 2008-03-25 06:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Proposed patch to fix Bug #461816 (39.84 KB, patch)
2007-09-06 19:58 UTC, Michael William Koehler 		accepted-commit_after_freeze Details | Review

Description Stephane Raimbault 2007-07-30 14:25:00 UTC 
Please describe the problem:
The following string is shown after a checkbox so the character ':' it's not necessary.

#: ../Src/DasherCore/SocketInputBase.cpp:34
msgid "Print socket-related debugging information to console:"


Frame titles musn't have a character ':' at the end (see GNOME HIG). It seems all frames are concerned.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Stephane Raimbault 2007-07-30 14:46:24 UTC 
*** Bug 461815 has been marked as a duplicate of this bug. ***
Comment 2 Michael William Koehler 2007-09-06 19:58:18 UTC 
Created attachment 95082 [details] [review]
Proposed patch to fix Bug #461816

This patch is a fix for Bug #461816.  It includes trivial changes - mostly punctuation.

==ChangeLog Entry (Not Included)==

2007-09-01  Michael Koehler  <mkoehle1@nd.edu>

     * Patched #461816
     * Tweaked glade files and SocketInputBase.cpp

==End Changelog Entry==

This is my first bug fix, so please tell me if I need to do anything differently before I take on complex bugs.
Comment 3 Phil Cowans 2008-03-02 18:43:15 UTC 
Thanks for the patch - this has been accepted, will commit after branching for the freeze.
Comment 4 Aaron Larson 2008-03-23 17:52:44 UTC 
Be warned that the patch here overlaps with bug 506900.  They will be interesting to resolve.  Phil, I'm going to review the patch for bug 506900 the commit it.  It might be easier to just hand translate this patch afterwords, which I can do.  I'll take this bug.
Comment 5 Aaron Larson 2008-03-25 06:22:37 UTC 
Changes were integrated in patch applied for bug 506900 in r3479.