After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 457533 - Show both elapsed and remaining track time (PATCH)
Show both elapsed and remaining track time (PATCH)
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-07-16 23:52 UTC by Thomas Zander
Modified: 2018-05-24 12:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to lib/rb-util.c (2.16 KB, patch)
2007-07-16 23:54 UTC, Thomas Zander
none Details | Review
Patch to rb-util.c and the other modules using the patched function (6.41 KB, patch)
2007-08-14 16:15 UTC, Thomas Zander
none Details | Review

Description Thomas Zander 2007-07-16 23:52:42 UTC
The attached patch formats the time string in rb_make_elapsed_time_string() in rb-util.c differently, so that the shell and the tray popup show the elapsed and remaining track time.
However, this renders the last argument of the function, gboolean show_remaining, unused. Is this function part of a frozen API? Is it acceptable to simply remove this argument?
Comment 1 Thomas Zander 2007-07-16 23:54:56 UTC
Created attachment 91879 [details] [review]
Patch to lib/rb-util.c
Comment 2 Thomas Zander 2007-08-14 16:15:56 UTC
Created attachment 93652 [details] [review]
Patch to rb-util.c and the other modules using the patched function

This patch allows to show elapsed, remaining time or both. A new gconf key was necessary to choose between these three possibilities.
Comment 3 Thomas Zander 2007-12-25 10:00:10 UTC
I would really appreciate some kind of statement from a developer about this feature. Does it have a chance to get accepted upstream or not? If not, what do I have to improve?
Comment 4 GNOME Infrastructure Team 2018-05-24 12:42:49 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/405.