After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 455964 - Tabs does not close cleanly due to missing toggle ref in pygtk
Tabs does not close cleanly due to missing toggle ref in pygtk
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Tabs
2.19.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
: 459319 474525 475013 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-07-11 16:20 UTC by Götz Waschk
Modified: 2007-09-19 14:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description Götz Waschk 2007-07-11 16:20:02 UTC
This is on Mandriva Cooker:
Epiphany 2.19.5

Mozilla/5.0 (X11; U; Linux i686; en; rv:1.8.1.4) Gecko/20070208 Mandriva/2.0.0.4-5mdv2008.0 (2008.0) Epiphany/2.18 Firefox/2.0.0.4

When I open a tab, play a video from youtube and close the tab with the video still playing, it is not stopped, the sound continues to play.

This does not happen with the firefox version my epiphany is based on.
Comment 1 Christian Persch 2007-07-11 16:40:04 UTC
Do you have the 'undo-tab-close' extension installed maybe ?
Comment 2 Götz Waschk 2007-07-11 17:46:46 UTC
No, I don't have that extension.
Comment 3 Christian Persch 2007-07-12 16:33:37 UTC
It can happen that sound continues for a second or so, but I've never seen this for more than that...

BTW:

Mozilla/5.0 (X11; U; Linux i686; en; rv:1.8.1.4) Gecko/20070208
Mandriva/2.0.0.4-5mdv2008.0 (2008.0) Epiphany/2.18 Firefox/2.0.0.4

This UA string is longer than 127 characters, which will cause a bug in the java plugin; please file a mandriva bug to get the string shortened.
Comment 4 Joel Stanley 2007-07-18 04:52:14 UTC
I see this in 2.19.5, using "Shockwave Flash 9.0 r48" on ubuntu gutsy, latest as of July 18.

The flash plugin windows are not terminated when closing tabs. They continue to play, and can be seen "popping out" into their own windows when epiphany is closed, before finally dissapearing.
Comment 5 Gustavo Carneiro 2007-08-06 13:46:39 UTC
I have this problem as well.  In addition, I have a problem that I suspect is related: the epiphany process keeps running in background even after closing all tabs and windows.
Comment 6 Jan Mynarik 2007-08-06 14:40:25 UTC
See details in Ubuntu bug:
https://bugs.launchpad.net/bugs/125209

Looks like it's problem with epiphany-extensions' code or with support for extensions in epiphany itself. Not only flash problem.
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2007-08-19 07:56:36 UTC
I'm using gutsy too, I have the same problem.
Comment 8 Gustavo Carneiro 2007-08-19 10:39:39 UTC
This could be due to pygobject bug 466082.  At least the reporter there says: "Symptoms have been seen so far mostly in Epiphany: failure to shut down,
extensions breaking continually, etc.  Fun."
Comment 9 Enver ALTIN 2007-08-20 08:59:33 UTC
Again on Gutsy, same problem here. I'm not really sure but I also believe that when closed tabs are not destroyed at all, so it keeps growing in memory size.
Comment 10 Sebastien Bacher 2007-08-20 13:05:02 UTC
The pygobject patch doesn't seem to fix the issue, when the cc-license-viewer is used epiphany still doesn't close correctly
Comment 11 Gustavo Carneiro 2007-08-26 11:28:20 UTC
I made the Creative Commons plugin work.  The problem was the line:

	eventbox.set_tooltip_text (_("View Creative Commons license"))

gtk.Widget.set_tooltip_text only exists since pygtk/gtk 2.12.  If you have an earlier pygtk version an exception is raised when the plugin attaches to the tab, and it all goes downhill from there.  Updating pygtk to 2.12 fixed the issue and epiphany started shutting down correctly.  I haven't tried any other python extension, though...

At least I tested this in jhbuild epiphany and pygtk.  The pygtk installed in ubuntu gutsy has gtk.Widget.set_tooltip_text, so in theory it should work in ubuntu; i'm going to try ubuntu next and report back...
Comment 12 Gustavo Carneiro 2007-08-26 11:32:50 UTC
I was wrong, ubuntu gutsy pygtk version is not recent enough:

Traceback (most recent call last):
  • File "/usr/lib/epiphany/2.19/extensions/cc-license-viewer.py", line 435 in attach_window
    ui_init(window)
  • File "/usr/lib/epiphany/2.19/extensions/cc-license-viewer.py", line 371 in ui_init
    eventbox.set_tooltip_text (_("View Creative Commons license"))
AttributeError: 'gtk.EventBox' object has no attribute 'set_tooltip_text'

** (epiphany:30700): WARNING **: Python code for 'attach_window' failed to execute

>>> gtk.pygtk_version
(2, 10, 6)

I'm guessing we need a new PyGTK 2.11.x release out... :P

Though on the other hand it was not very wise of epiphany devs to release extensions requiring a unreleased PyGTK version :|
Comment 13 Gustavo Carneiro 2007-08-26 11:35:53 UTC
PS: it also isn't nice on the part of epiphany to fail to destroy a tab when an extension fails.
Comment 14 Sebastien Bacher 2007-09-07 11:45:42 UTC
The bug is still happening on gutsy using pygtk 2.11.0
Comment 15 Crispin Flowerday (not receiving bugmail) 2007-09-07 12:56:38 UTC
*** Bug 474525 has been marked as a duplicate of this bug. ***
Comment 16 Diego Escalante Urrelo (not reading bugmail) 2007-09-11 21:54:21 UTC
This is a dupe of #475013 isn't it?
Comment 17 Gustavo Carneiro 2007-09-11 22:45:36 UTC
(In reply to comment #16)
> This is a dupe of #475013 isn't it?

I would say so.. something is preventing a 'tab' to be finalized; this has two consequences: 1. plugins inside the tab keep running (e.g. flash), 2. epiphany must be looking for finalization signals of tabs, but since closing tabs doesn't finalize them then epiphany never quits.  So these are likely two symptons of the same single problem.
Comment 18 Diego Escalante Urrelo (not reading bugmail) 2007-09-18 21:31:30 UTC
*** Bug 475013 has been marked as a duplicate of this bug. ***
Comment 19 Diego Escalante Urrelo (not reading bugmail) 2007-09-18 21:34:53 UTC
Changing summary, this problem is caused by pygtk.
Disabling all the python extensions vanishes the problem. I can confirm that.
Comment 20 Diego Escalante Urrelo (not reading bugmail) 2007-09-18 21:55:46 UTC
*** Bug 459319 has been marked as a duplicate of this bug. ***
Comment 21 Diego Escalante Urrelo (not reading bugmail) 2007-09-18 21:56:42 UTC
From Wouter's bug report:

Breakpoint 2, IA__g_log (log_domain=0xb6eb429c "GLib-GObject", 
    log_level=G_LOG_LEVEL_WARNING, 
    format=0xb6eb539c "%s: couldn't find toggle ref %p(%p)") at gmessages.c:516
516       va_start (args, format);
(gdb) bt
  • #0 IA__g_log
  • #1 IA__g_object_remove_toggle_ref
    at gobject.c line 1709
  • #2 pygobject_dealloc
    at pygobject.c line 1051
  • #3 tupledealloc
    at ../Objects/tupleobject.c line 169
  • #4 call_python_func
    at ephy-python-extension.c line 232
  • #5 ephy_extension_attach_tab
    at ephy-extension.c line 78
  • #6 impl_attach_tab
    at ephy-extensions-manager.c line 1261
  • #7 ephy_extension_attach_tab
    at ephy-extension.c line 78
  • #8 notebook_page_added_cb
    at ephy-window.c line 2493
  • #9 _gtk_marshal_VOID__OBJECT_UINT
    at gtkmarshalers.c line 2401
  • #10 IA__g_closure_invoke
  • #11 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #12 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #13 IA__g_signal_emit
    at gsignal.c line 2243
  • #14 gtk_notebook_real_insert_page
    at gtknotebook.c line 4099
  • #15 ephy_notebook_insert_page
    at ephy-notebook.c line 742
  • #16 IA__gtk_notebook_insert_page_menu
    at gtknotebook.c line 6240
  • #17 IA__gtk_notebook_insert_page
    at gtknotebook.c line 6170
  • #18 ephy_notebook_add_tab
    at ephy-notebook.c line 763
  • #19 ephy_window_add_tab
    at ephy-window.c line 3448
  • #20 ephy_shell_new_tab_full
    at ephy-shell.c line 510
  • #21 session_command_dispatch
    at ephy-session.c line 740
  • #22 g_idle_dispatch
    at gmain.c line 4131
  • #23 IA__g_main_context_dispatch
    at gmain.c line 2061
  • #24 g_main_context_iterate
    at gmain.c line 2694
  • #25 IA__g_main_loop_run
    at gmain.c line 2898
  • #26 IA__gtk_main
    at gtkmain.c line 1144
  • #27 main
    at ephy-main.c line 723

Comment 22 Diego Escalante Urrelo (not reading bugmail) 2007-09-18 21:57:57 UTC
Some old related bugs: bug #317242 and bug #171261.
Comment 23 Gustavo Carneiro 2007-09-18 23:31:42 UTC
The problem is how to reproduce this.  With jhbuilt pygobject/pygtk/epiphany/epiphany-extensions I am not able to reproduce this problem anymore.  I activate all python extensions and the epiphany shell exits cleanly all the time, without the toggle ref warning.

I think this could be related to bug 466082.  However, only a couple of days ago was pygobject 2.14 released containing this fix.  Could people please try again with pygobject 2.14 and check that/if the problem goes away?
Comment 24 Jan Mynarik 2007-09-19 00:07:33 UTC
It seems that the problem is gone on up-to-date Ubuntu Gutsy - epiphany 2.20.0-0ubuntu1, epiphany-extensions 2.20.0-0ubuntu1, python-gobject/pygobject 2.14.0-0ubuntu1, python-gtk2/pygtk 2.12.0-0ubuntu1.

Everything works OK now! Thanks.
Comment 25 Diego Escalante Urrelo (not reading bugmail) 2007-09-19 01:00:49 UTC
It's gone here apparently, just checked with my up to date gutsy.
Comment 26 Wouter Bolsterlee (uws) 2007-09-19 14:05:11 UTC
Ok, seems fixed.