After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 444227 - file -> download messages for offline: mnemonic missing
file -> download messages for offline: mnemonic missing
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
aklapper[mnemonics] ghop[2007-15]
Depends on:
Blocks: 324810
 
 
Reported: 2007-06-05 06:04 UTC by vinod
Modified: 2013-09-13 00:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
this is the patch for the bug 444227 , the patch works fine (664 bytes, patch)
2007-06-05 06:05 UTC, vinod
none Details | Review
Updated patch for missing mnemonic (1.50 KB, patch)
2007-12-02 15:01 UTC, Alex Kloss
needs-work Details | Review
Revised patch (1.50 KB, patch)
2007-12-03 20:04 UTC, Alex Kloss
committed Details | Review

Description vinod 2007-06-05 06:04:08 UTC
In Evolution version 2.11.2
   in the main window 
   Select File --> the feature (download messages for offline )does not have mnemonic for easy keyboard navigation purpose...for the purpose to improve the usability feature 

Other information:
actual results :
 the keyboard navigation is not possible for the about mentioned option ,,as for the rest it is present

expected results :
  providing a mnemonic improves the usability feature ....
Comment 1 vinod 2007-06-05 06:05:53 UTC
Created attachment 89379 [details] [review]
this is the patch for the bug 444227 , the patch works fine
Comment 2 André Klapper 2007-06-05 13:59:51 UTC
uhm... right... grumble... who added that menu item, srini? ;-)
the string does not make sense.
"for offline" what? offline usage?
if so, reuse or shorten the existing string in the right-click menu of the folder properties (which also misses a mnemonic).

vinod, please don't use "usability" keyword for this. use "accessibility" and add a "blocks 324810" for any mnemonic issues. thanks in advance.
Comment 3 vinod 2007-06-06 07:48:52 UTC
  thnakz for the link andre  ;-), andre i did understand the second part you were talking about , regarding missing mnemonic in the right - click menu of the folder properties , i could not find any missing mnemonic , a little more specific would be more helpful :-),

   andre i was wondering in the file menu for the send/receive item ,
    the r is used as mnemonic , i would suggest for e to be the better option since matches best with  the standards and
    bcz it's the dual operation being performed over their , waiting for your're comment on that :-)

Comment 4 André Klapper 2007-06-06 08:43:49 UTC
(any remote folder) right-click -> properties -> mark for offline usage
Comment 5 Srinivasa Ragavan 2007-06-09 19:57:57 UTC
Vinod, please resubmit the path with string modification as Andre suggested.
Comment 6 vinod 2007-06-11 11:21:39 UTC
(In reply to comment #4)
> (any remote folder) right-click -> properties -> mark for offline usage
> 

srag ok, will be working on that soon ,
Comment 7 Alex Kloss 2007-12-02 15:01:10 UTC
Created attachment 100043 [details] [review]
Updated patch for missing mnemonic

This patch is the same as the first, except that it changes the string to "Mark for offline usage" as Andre suggested and creates a mnemonic for it, and the new menu item string is "Download messages for offline usage".
Comment 8 André Klapper 2007-12-02 18:43:20 UTC
cool.
Comment 9 Milan Crha 2007-12-03 16:26:27 UTC
a) I cannot apply the patch:
patching file ui/evolution-mail-global.xml
patch: **** unexpected end of file in patch

b) are you sure you want to have same thing named differently in menu and popup menu? Is it good idea? I think it's a bit confusing for users, isn't it?
Comment 10 Alex Kloss 2007-12-03 20:04:45 UTC
Created attachment 100141 [details] [review]
Revised patch

I'm not sure why we received this error; it may have been a problem with my editor.

In any case, I've regenerated the patch and changed the two affected strings to "Download messages for offline usage" using mnemonic 'd' for both. The patch should apply cleanly this time :)
Comment 11 Milan Crha 2007-12-04 11:58:12 UTC
OK, looks good to commit.
Comment 12 Milan Crha 2007-12-04 11:59:07 UTC
Committed to trunk. Committed revision 34641.