After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 441610 - [verified] Orca should identify bogus/redundant checkbox labels in Firefox
[verified] Orca should identify bogus/redundant checkbox labels in Firefox
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.19.x
Other All
: Normal normal
: 2.20.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2007-05-27 15:40 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
patch to hopefully solve the problem (1.61 KB, patch)
2007-05-27 18:55 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-05-27 15:40:46 UTC 
Steps to reproduce:

1. Navigate to GNOME's bugzilla Advanced Search page
2. Tab until you get to the collection of checkboxes

Expected results:  Orca would speak the checkbox labels only once.

Actual results:  Orca speaks them twice.

Note:  This seems to be unique to the Advanced Search page and will likely require a specific bogusity check similar to what was needed for GNOME bugzilla's combo boxes (see bug 428114) and lists (see bug 441476).
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-05-27 18:13:23 UTC 
The source of the bogusity in this case seems to be a combination of GNOME's bugzilla label markup and the Firefox HTML whitespace bug.

<sarcasm>Woo hoo! Let's hear it for team work!</sarcasm>

Sorry, I feel much better now. :-) 

With the checkbox labels in question, bugzilla markup is:

      <label for="emailreporter1">
        the reporter
      </label>

As a result, _getSpeechForCheckbox() does this:

           utterances:
               (         the reporter       )
               (the reporter)
               (check box)
               (not checked)

Unlike the other bugzilla mark-up issues, there is a healthy chance of this occurring on other pages.  Now to figure out where to handle it....
Comment 2 Joanmarie Diggs (IRC: joanie) 2007-05-27 18:55:16 UTC 
Created attachment 88899 [details] [review]
patch to hopefully solve the problem

Mike please test.  Thanks!
Comment 3 Mike Pedersen 2007-05-28 01:43:41 UTC 
Looks great! thanks
Comment 4 Joanmarie Diggs (IRC: joanie) 2007-05-28 02:58:04 UTC 
Thanks Mike.  Patch committed.  Given the small size of the change and Mike's verified status, closing as FIXED.