GNOME Bugzilla – Bug 433064
Plugins are not deactivated on Totem exit
Last modified: 2007-04-25 12:45:05 UTC
totem_object_finalize and so totem_plugins_engine_shutdown is never called on totem exit.
Created attachment 86934 [details] [review] Move totem_plugins_engine_shutdown to totem_action_exit Additional this patch removes workarounds in the media player keys and lirc plugins.
The work-arounds being removed look fine, but wouldn't it be easier to g_object_unref the TotemObject when exiting, rather than what's in your patch?
g_object_unrefing a TotemObject in the totem_action_exit function didn't fixed the problem. There are probably to much references of the TotemObject around.
As we already have a totem_object_plugins_init(), could you please add a totem_object_plugins_shutdown() which shuts down the plugin engine as above. That'd do fine for me.
Created attachment 86985 [details] [review] Add totem_object_plugins_shutdown ().
Looks good, thanks!
2007-04-25 Jan Arne Petersen <jpetersen@jpetersen.org> * src/plugins/lirc/totem-lirc.c: (totem_lirc_plugin_finalize): * src/plugins/media-player-keys/totem-media-player-keys.c: (totem_media_player_keys_plugin_finalize): * src/totem-object.c: (totem_object_finalize), (totem_object_plugins_shutdown): * src/totem.c: (totem_action_exit): * src/totem.h: Explicitly shutdown the plugins engine at the totem exit. Remove workarounds. (Closes: #433064)