GNOME Bugzilla – Bug 376863
Rhythmbox should offer an option to configure the default action of mouse roll event on tray icon
Last modified: 2009-07-22 15:40:38 UTC
The default action for mouse roll event on tray icon is to change the volume, i suggest a configurable option on the preferences for this action with the options: -Default (Changes the volume) -Change Tracks (next or previous) -Change Volume (following other models) Im an old user of Banshee and banshee changes the track based on the roll event on tray, im very addicted to that and i would like to see that in rhythmbox.
Created attachment 76823 [details] [review] Proposed feature patch against CVS HEAD This is the patch with the feature i requested.
Did anyone take a look at this patch yet?
Sorry for not looking at this, it must have fallen though the cracks. The code looks fine, aside from some minor coding-style nitpicks (braces on the same line as if statements, spaces around the ||). There were plans to replace our use of EggTrayIcon with GtkTrayIcon sometime, which would impact on this, since GtkTrayIcon doesn't support middle-click/scroll event currently (there is an enhancement bug filed about it).
why not implement it until the other patch comes?
since we are approaching the new release, can we have at least a gconf key for this? might solve the problem temporarily
*** Bug 484365 has been marked as a duplicate of this bug. ***
*** Bug 550847 has been marked as a duplicate of this bug. ***
*** Bug 558871 has been marked as a duplicate of this bug. ***
If someone is still interested in this, the patch would need to be reworked to apply to the new status icon plugin.
im still looking forward to have it, if possible.
Created attachment 138306 [details] [review] Proposed feature patch against 0.12.3 I've made a patch against the version 0.12.3 to do what was requested.
This generally looks OK to me. A couple of things that need to be fixed: you need to add the new gconf key to the gconf schema file (data/rhythmbox.schemas), and there's an unnecessary whitespace change: @@ -1120,7 +1143,7 @@ maybe_upgrade_preferences (RBStatusIconP rb_debug ("using old gconf key " CONF_OLD_NOTIFICATIONS " to set notify mode to %d", new_mode); eel_gconf_set_integer (CONF_NOTIFICATION_MODE, new_mode); } - + /* apply old window visibility key */ if (should_upgrade (CONF_OLD_VISIBILITY, CONF_WINDOW_VISIBILITY)) { gboolean visible = eel_gconf_get_boolean (CONF_OLD_VISIBILITY);
Created attachment 138338 [details] [review] Proposed feature patch against 0.12.3 I think that I fixed everything you asked. Should I try it against the svn version?
Looking at this again, I think the way the modes are handled in rb_status_icon_plugin_scroll_event is a bit ugly - something like: switch (mode) { case WHEEL_VOLUME: switch (direction) { .. set adjust value .. } set_volume_relative(adjust); break; case WHEEL_SONG: switch (direction) { .. change song based on direction .. } } would be better. In general, when you're submitting patches, it's better if they're made against git master (http://git.gnome.org/cgit/rhythmbox/), but in this case a patch against 0.12.3 is fine.
Created attachment 138401 [details] [review] Proposed feature patch against 0.12.3 Ok, last time I've done that way because I didn't wanted to change your code too much, but I fixed it now.
So... anymore fixes to do? I'm really looking forward to this enhancement. Thanks.
No, it's just been waiting for me to find time to review, test, and commit it.. but I've done that now. Thanks for working on this.
Thanks =]