After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 363825 - Narrowspace unable to cope with E<> in QT_WriteOBJECT_XHTML
Narrowspace unable to cope with E<> in QT_WriteOBJECT_XHTML
Status: VERIFIED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: totem-browser-maint
totem-browser-maint
: 355014 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-21 03:11 UTC by Wade Menard
Modified: 2006-10-26 07:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Wade Menard 2006-10-21 03:11:22 UTC
Totem 2.16.1

Web Page: http://onegoodmove.org/1gm/1gmarchive/2006/10/bush_unfit_for.html

The page uses
QT_WriteOBJECT_XHTML('http://onegoodmovemedia.org/movies/0610/ko100506specialcommentp.mov', '320', '256','','controller','false','autoplay','true','cache','false','href','<http://onegoodmovemedia.org/movies/0610/ko100506specialcomment.mov> E<autoplay=true controller=true>','target','myself','enablejavascript','true');

The Narrowspace plugin attempts to play the URL starting at http but does not stop at the first '>' but the second '>'.

Result:
tries to play
"http://.../ko100506specialcomment.mov> E<autoplay=true controller=true"
instead of the expected
"http://../ko100506specialcomment.mov"
Comment 1 Wade Menard 2006-10-21 03:44:05 UTC
The problem exists under gnome CVS HEAD as well
Comment 2 Bastien Nocera 2006-10-21 07:01:28 UTC
And how is that not a typo in the website? :)
Comment 3 Bastien Nocera 2006-10-21 07:08:47 UTC
This is what the browser passes us:

argv[0] src http://onegoodmovemedia.org/movies/0610/ko100506specialcommentp.mov
argv[1] pluginspage http://www.apple.com/quicktime/download/
argv[2] controller false
argv[3] autoplay true
argv[4] cache false
argv[5] href <http://onegoodmovemedia.org/movies/0610/ko100506specialcomment.mov> E<autoplay=true controller=true>
argv[6] target myself
argv[7] enablejavascript true
argv[8] height 256
argv[9] width 320

I don't really think we're expected to parse the href ourselves...
Comment 4 Wade Menard 2006-10-21 12:52:09 UTC
Totem seems to be parsing it at some point judging by the not found error not mentioning the first "<" and last ">".

It didn't seem like a typo to me so I did some digging. The "feature" (since Quicktime 5) is summarized here (New URL Extensions)
http://developer.apple.com/documentation/QuickTime/WhatsNewQT5/QT5NewChapt1/chapter_1_section_32.html

> Syntax
> "<URL> T<Target> E<ParamA=Value ParamB=Value ... >"

And detailed here:
http://developer.apple.com/documentation/QuickTime/Conceptual/QTScripting_HTML/QTScripting_HTML_Document/chapter_1000_section_3.html

It looks like we could have a problem with T<> as well. I assumed the simple fix for now is to stop at the first ">", assuming URL is expected to be first. Even better would to to pass the params to where they need to go.

Comment 5 Wade Menard 2006-10-21 13:01:10 UTC
I noticed the passed args conflicted on controller= not matching between the html and the href=, but the docs cleared that up:

>QuickTime resolves any such conflicts by giving first priority to HTML, next
>priority to settings embedded using Plugin Helper, and last priority to settings
>specified by user preferences.
Comment 6 Bastien Nocera 2006-10-21 16:20:23 UTC
Fair enough, I'll see what we can do.
Comment 7 Bastien Nocera 2006-10-21 20:16:52 UTC
I added basic support. For the controller part, we'll need to refactor a bit more to support the other possible parameters (see bug 364017). I also found a problem similar to bug 353097, in which we don't resolve the HREF properly.

2006-10-21  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/totemPlugin.cpp: Add basic support for Quicktime
        URL extensions (Closes: #363825)

Fixed in HEAD.
Comment 8 Wade Menard 2006-10-21 23:33:53 UTC
Wow, that was fast! Kudos!

Verified Fixed.
Comment 9 Bastien Nocera 2006-10-26 07:47:28 UTC
*** Bug 355014 has been marked as a duplicate of this bug. ***