After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 362907 - Give Draft/Sent folders appropriate icons in the folder view
Give Draft/Sent folders appropriate icons in the folder view
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other All
: Normal enhancement
: ---
Assigned To: Milan Crha
Evolution QA team
: 323145 428620 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-17 17:10 UTC by Sam Morris
Modified: 2009-06-05 09:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
proposed evo patch (1.92 KB, patch)
2009-06-04 18:08 UTC, Milan Crha 		reviewed Details | Review
ya wanna see it? (11.61 KB, image/png)
2009-06-04 18:10 UTC, Milan Crha 		  Details

Description Sam Morris 2006-10-17 17:10:37 UTC 
It would be nice if folders that have been selected to be the Draft or Sent mail folders for accounts wouuld be given icons that indicate their special status.

The Local folders' Sent folder already has such an icon, but there does not seem to be a suitable icon for the Drafts folder.

Other information:
Comment 1 Akhil Laddha 2008-08-06 05:09:07 UTC 
At least sent item folder has different icon in Local, Group wise and Exchange providers. Draft folder still doesn't have.
Comment 2 Matthew Barnes 2008-08-06 13:29:32 UTC 
I've always thought GTK_STOCK_EDIT would be a nice icon for Drafts.
Comment 3 Paul Bolle 2008-09-08 23:06:44 UTC 
The template plugin (which I haven't used at all) creates a Templates folder, which seems special too. Might make sense to give it a special icon too.
Comment 4 Paul Bolle 2008-09-08 23:10:36 UTC 
Might this bug be summarized as "Give all special message folders a special icon"?

If that's not too broad bug #428620 (which is about IMAP) could be closed duplicate of this bug.
Comment 5 Matthew Barnes 2009-05-24 20:38:26 UTC 
*** Bug 323145 has been marked as a duplicate of this bug. ***
Comment 6 Milan Crha 2009-06-04 17:22:16 UTC 
*** Bug 428620 has been marked as a duplicate of this bug. ***
Comment 7 Milan Crha 2009-06-04 18:08:00 UTC 
Created attachment 135965 [details] [review]
proposed evo patch

for evolution;

quite simple, but would like to know Matt's opinion. This also adds icons on drafts/sent folder on an account it the folder is from that account.
Comment 8 Milan Crha 2009-06-04 18:10:05 UTC 
Created attachment 135966 [details]
ya wanna see it?
Comment 9 Matthew Barnes 2009-06-04 22:09:06 UTC 
Logic looks okay, though I have to reiterate my complaint about Camel not knowing about accounts.  Would be nice if folder metadata was all in one place.  (Ignore me, I'm just venting.)

Icon names: For Templates use "text-x-generic-template" instead of "tab-new" (templates are not tabs).  "gtk-edit" is fine for Drafts but maybe consider "accessories-text-editor", just so we're sticking with standard icon names.
Comment 10 Milan Crha 2009-06-05 09:06:09 UTC 
Created commit 75ef38d in evo master.

Pretty the same as the proposed fix, just changed icon names as suggested and also didn't change the 'flags', but added 'add_flags' there.