GNOME Bugzilla – Bug 362603
Fixes compiling with forte: warning clean up (part 4)
Last modified: 2006-10-16 18:23:14 UTC
Please describe the problem: ext/cairo/gsttimeoverlay.c: arithmethics with a void pointer ext/esd/esdsink.c: arithmethics with a void pointer ext/flac/gstflacdec.c: wrong enumeration constants ext/flac/gstflacenc.c: wrong enumeration constants ext/jpeg/smokecodec.c: change DEBUG() for GST_DEBUG() gst/avi/gstavimux.c: overflow gst/debug/efence.c: arithmethics with a void pointer gst/goom/Makefile.am: change GST_BASE_CFLAGS for GST_CFLAGS(-Werror) gst/goom/gstgoom.c: diferent return type between declaration and definition gst/icydemux/gsticydemux.c: wrong type gst/rtsp/gstrtspsrc.c: right type is GstURIType gst/rtsp/rtspconnection.c:HAVE_FIONREAD_IN_SYS_FILIO and arithmethics with a void pointer gst/udp/gstudpsink.c: right type is GstURIType gst/udp/gstudpsrc.c: right type is GstURIType gst/wavparse/gstwavparse.c: (GstState) cast required sys/sunaudio/gstsunaudiomixertrack.h: diferent type between declaration and definition Steps to reproduce: Compile it with Forte Actual results: Expected results: Does this happen every time? Other information:
Created attachment 74810 [details] [review] [patch] Fixes the bugs
Three small nitpicks: - config.h should always be included as very first file (rtspconnection.c patch) - why the removal of $(GST_BASE_CFLAGS) in gst/goom/Makefile.am? GstAdapter is used in goom code AFAICS. Maybe you just wanted to add $(GST_CFLAGS) ? - in smokedec/enc: there shouldn't be \n chars at the end of GST_DEBUG lines :)
Created attachment 74826 [details] [review] [patch] Fixes the bugs With the changes suggested by Tim.
Thanks a lot, committed: 2006-10-16 Tim-Philipp Müller <tim at centricular dot net> Patch by: Josep Torra Valles <josep at fluendo com> * ext/cairo/gsttimeoverlay.c: (gst_cairo_time_overlay_transform): * ext/esd/esdsink.c: (gst_esdsink_write): * ext/flac/gstflacdec.c: (gst_flac_dec_length), (gst_flac_dec_read_seekable), (gst_flac_dec_chain), (gst_flac_dec_send_newsegment): * ext/flac/gstflacenc.c: (gst_flac_enc_seek_callback), (gst_flac_enc_tell_callback): * ext/jpeg/smokecodec.c: (find_best_size), (smokecodec_encode), (smokecodec_parse_header), (smokecodec_decode): * gst/avi/gstavimux.c: (gst_avi_mux_write_avix_index): * gst/debug/efence.c: (gst_fenced_buffer_alloc): * gst/goom/Makefile.am: * gst/goom/gstgoom.c: * gst/icydemux/gsticydemux.c: (gst_icydemux_typefind_or_forward): * gst/rtsp/gstrtspsrc.c: * gst/rtsp/rtspconnection.c: (rtsp_connection_read): * gst/udp/gstudpsink.c: * gst/udp/gstudpsrc.c: * gst/wavparse/gstwavparse.c: (gst_wavparse_change_state): * sys/sunaudio/gstsunaudiomixertrack.h: Fix a bunch of problems discovered by the Forte compiler, mostly type mixups and pointer arithmetics with void pointers. Fixes #362603. (removed that debug statement in gstwavparse altogether though).