After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357180 - [libs] gst_controller_new* functions don't increase refcount if needed
[libs] gst_controller_new* functions don't increase refcount if needed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: 0.10.11
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-22 11:10 UTC by René Stadler
Modified: 2006-10-11 09:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Also fix gst_controller_new_list correctly (1.14 KB, patch)
2006-10-11 06:00 UTC, René Stadler 		committed Details | Review

Description René Stadler 2006-09-22 11:10:19 UTC 
In gstreamer/libs/gst/controller/gstcontroller.c, if the functions gst_controller_new_list, gst_controller_new_valist (and therefor gst_controller_new) return an existing instance, the reference count is not increased.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2006-09-22 13:33:43 UTC 
2006-09-22  Stefan Kost  <ensonic@users.sf.net>

	* libs/gst/controller/gstcontroller.c: (gst_controller_new_valist),
	(gst_controller_new_list):
	  Ref instances when returning them again (fixes #357180)
Comment 2 René Stadler 2006-10-11 05:55:54 UTC 
This was fixed incorrectly and corrected by Tim (see bug #357617 for changelog entry), but only for gst_controller_new_valist.  gst_controller_new_list is right below that, with almost identical code that is still broken.  Patch follows that copies over Tim's changes over to the other function, too.
Comment 3 René Stadler 2006-10-11 06:00:32 UTC 
Created attachment 74463 [details] [review]
Also fix gst_controller_new_list correctly
Comment 4 Tim-Philipp Müller 2006-10-11 09:13:59 UTC 
Thanks, committed with test:

 2006-10-11  Tim-Philipp Müller  <tim at centricular dot net>

        * libs/gst/controller/gstcontroller.c: (gst_controller_new_list):
          Fix refcounting here too, just like we did for _new_valist() a few
          days ago (#357180) (thanks to René Stadler). Also remove all those
          'Since: 0.9' from the gtk-doc blobs.

        * tests/check/libs/controller.c: (controller_refcount_new_list),
        (gst_controller_suite):
          Unit test for the above.