After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345541 - Intelligent scissors inconsistent with other selection tools (usage of Shift, Ctrl)
Intelligent scissors inconsistent with other selection tools (usage of Shift,...
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal minor
: ---
Assigned To: GIMP Bugs
GIMP Bugs
: 766397 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-06-21 13:23 UTC by Raphaël Quinet
Modified: 2018-05-24 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Raphaël Quinet 2006-06-21 13:23:55 UTC
Please describe the problem:
Contrary to all other selection tools, the intelligent scissors ignore the initial state of the Shift and Ctrl modifiers that are used to choose between the modes replace/add/subtract/intersect.  The state of these modifiers is only considered once the path is closed and converted to a real selection.

The current status bar messages used for iscissors are similar to all other selection tools and could lead the user to believe that the pressing Shift or Ctrl before the first mouse click is sufficient.  However, this is not the case here.  The user must either keep them pressed all the time, or remember to press them (again) just before converting the iscissors line to a selection.

For consistency reasons, it would be better to modify iscissors so that it behaves like all other selection tools: consider the initial state of the modifiers, not their final state.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Sven Neumann 2006-06-21 15:12:34 UTC
For intelligent scissors, it really doesn't make any sense to look at the state of the modifier keys before the user has even started to draw the selection outline. Just like the SIOX tool, the modifier keys are relevant when the Enter key is pressed to convert the selected area to a selection. That's when the selection is actually created, so there's no inconsistency. We just need to make sure that the statusbar messages are shown at the right time.
Comment 2 Raphaël Quinet 2006-06-21 15:58:05 UTC
I disagree because I think that most users would expect the initial state of the modifiers to be relevant (like for the rectangle/ellipse selection tools and others).  Relying only on the final state could be confusing if modifiers can also be used for something else while the points are being defined.  For example, a modifier (Ctrl?) could be used to delete a point instead of adding a new one.

I will soon post a message to the gimp-developer list about the status bar messages and I think that they would be easier to understand if the initial state of the modifiers is taken into consideration for all selection tools.  Other tools such as the zoom tool (magnify) and the transform tools also consider only the initial state of the modifiers and ignore subsequent changes while the user is clicking/dragging.
Comment 3 Wil Barath 2013-11-17 23:06:22 UTC
Indeed, this is exactly what I expected - to be able to create a negative selection to remove a portion of a previous selection I had made with the scissors, just like I can do with any other selection tool.

I see both sides of this argument though.

My suggestion is that the intelligent scissors tool be turned into a path tool instead, and then let the user turn that path into a selection.  Because that is *almost* what it is not.  Currently it fails to be either a selection or a path.
Comment 4 Wil Barath 2013-11-17 23:07:44 UTC
Sorry, typo.

... *almost* what is is now. ...
Comment 5 Michael Schumacher 2016-05-14 12:15:09 UTC
*** Bug 766397 has been marked as a duplicate of this bug. ***
Comment 6 Alexandre Prokoudine 2016-08-04 11:45:18 UTC
Additionally, IScissors should use Backspace to remove the last placed node to be consistent with the Path tool.
Comment 7 Michael Natterer 2016-11-08 12:46:59 UTC
The last request is done now:

commit 7c29077acd459b091ff41846c564074d4b1d9408
Author: Michael Natterer <mitch@gimp.org>
Date:   Tue Nov 8 13:45:12 2016 +0100

    app: allow to remove the last added IScissors segment with backspace

 app/tools/gimpiscissorstool.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)
Comment 8 GNOME Infrastructure Team 2018-05-24 11:51:19 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/197.