After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344383 - use po/LINGUAS
use po/LINGUAS
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.9.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 344332 (view as bug list)
Depends on: 344381
Blocks: 338162 339259 339264
 
 
Reported: 2006-06-09 12:01 UTC by Christian Kirbach
Modified: 2008-08-02 04:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Use LINGUAS file (2.29 KB, patch)
2008-05-15 20:19 UTC, Claude Paroz
committed Details | Review

Description Christian Kirbach 2006-06-09 12:01:31 UTC
see http://live.gnome.org/GnomeGoals/PoLinguas

I started work on a patch
Comment 1 Matthias Clasen 2006-06-09 12:53:33 UTC
I think this is a very low priority change; we don't add new languages every day.

I'd consider a patch after 2.10 is out.
Comment 2 Behdad Esfahbod 2006-06-09 19:34:20 UTC
*** Bug 344332 has been marked as a duplicate of this bug. ***
Comment 3 Luis Menina 2006-08-16 08:37:52 UTC
Well, 2.10 is out now :)
Comment 4 Christian Kirbach 2006-08-16 13:01:00 UTC
... and meanwhile I've discarded my work.
Comment 5 Lucas Rocha 2006-12-19 22:39:19 UTC
Matthias, considering you don't plan to make glib depend on intltool at all (as you commented on bug #338162), shouldn't be this bug report closed as WONTFIX?
Comment 6 Matthias Clasen 2006-12-20 03:05:17 UTC
Well, using po/LINGUAS doesn't necessarily mean using intltool.
Comment 7 Johan (not receiving bugmail) Dahlin 2008-03-02 18:15:55 UTC
I agree with Matthias, intltool should be avoided.

Christian: are you interested in providing a patch which makes gtk+ use po/LINGUAS?
Comment 8 Claude Paroz 2008-05-15 20:19:59 UTC
Created attachment 110973 [details] [review]
Use LINGUAS file

Here is a simple patch based on the similar work of Thomas Andersen for glib, without intltool dependance.
Comment 9 Matthias Clasen 2008-05-20 18:11:45 UTC
Looks basically fine. 
Do we need to add the LINGUAS files to an EXTRA_DIST somewhere to get them into tarballs generated by make dist ?
Comment 10 Gil Forcada 2008-06-09 01:38:11 UTC
At least nautilus, evolution and epiphany doesn't seem to add it to EXTRA_DIST
Comment 11 André Klapper 2008-06-13 20:21:56 UTC
can we get this in now that glib has also been fixed?
Comment 12 André Klapper 2008-06-29 02:32:20 UTC
PING.
Comment 13 Emmanuele Bassi (:ebassi) 2008-07-21 13:16:53 UTC
I'm not Matthias, but I guess that since his question was answered, we can get this in. po/LINGUAS is only needed when regenerating the configure script from the template - and that is not needed inside tarballs.
Comment 14 Matthias Clasen 2008-07-21 13:49:04 UTC
But it still should be shipped in the tarballs.
Thats what EXTRA_DIST is all about...
Comment 15 Emmanuele Bassi (:ebassi) 2008-07-21 14:26:28 UTC
(In reply to comment #14)
> But it still should be shipped in the tarballs.

I'm fuzzy on the why. the tarball will not use it, and as far as I can see in glib and other projects don't add it to EXTRA_DIST.
Comment 16 Matthias Clasen 2008-07-21 14:57:12 UTC
I think I complained about that in glib as well.

Basically, in my opinion, the tarball should be complete enough to be a full snapshot of svn at the point of release. Ie it should contain everything that is under source control, even if it is not needed for building from the tarball.
Comment 17 Emmanuele Bassi (:ebassi) 2008-07-21 14:59:51 UTC
(In reply to comment #16)
> I think I complained about that in glib as well.
> 
> Basically, in my opinion, the tarball should be complete enough to be a full
> snapshot of svn at the point of release. Ie it should contain everything that
> is under source control, even if it is not needed for building from the
> tarball.

ah, now I understand - and after looking at Makefile.am, I can see the tarball also ships autogen.sh.

then yes: po/LINGUAS should go in EXTRA_DIST as well.

Comment 18 Matthias Clasen 2008-07-31 05:48:49 UTC
Comparing with glib, please add LINGUAS to the DISTFILES variable in po/Makefile.in.in when committing. Thanks.
Comment 19 Matthias Clasen 2008-08-02 04:23:45 UTC
2008-08-02  Matthias Clasen  <mclasen@redhat.com>

        Bug 344383 – use po/LINGUAS

        * po/LINGUAS: New file, to make translators happy.
        * configure.in: Use po/LINGUAS
        * po/Makefile.in.in: Add po/LINGUAS to DISTFILES
        Patch by Claude Paroz