GNOME Bugzilla – Bug 344383
use po/LINGUAS
Last modified: 2008-08-02 04:23:45 UTC
see http://live.gnome.org/GnomeGoals/PoLinguas I started work on a patch
I think this is a very low priority change; we don't add new languages every day. I'd consider a patch after 2.10 is out.
*** Bug 344332 has been marked as a duplicate of this bug. ***
Well, 2.10 is out now :)
... and meanwhile I've discarded my work.
Matthias, considering you don't plan to make glib depend on intltool at all (as you commented on bug #338162), shouldn't be this bug report closed as WONTFIX?
Well, using po/LINGUAS doesn't necessarily mean using intltool.
I agree with Matthias, intltool should be avoided. Christian: are you interested in providing a patch which makes gtk+ use po/LINGUAS?
Created attachment 110973 [details] [review] Use LINGUAS file Here is a simple patch based on the similar work of Thomas Andersen for glib, without intltool dependance.
Looks basically fine. Do we need to add the LINGUAS files to an EXTRA_DIST somewhere to get them into tarballs generated by make dist ?
At least nautilus, evolution and epiphany doesn't seem to add it to EXTRA_DIST
can we get this in now that glib has also been fixed?
PING.
I'm not Matthias, but I guess that since his question was answered, we can get this in. po/LINGUAS is only needed when regenerating the configure script from the template - and that is not needed inside tarballs.
But it still should be shipped in the tarballs. Thats what EXTRA_DIST is all about...
(In reply to comment #14) > But it still should be shipped in the tarballs. I'm fuzzy on the why. the tarball will not use it, and as far as I can see in glib and other projects don't add it to EXTRA_DIST.
I think I complained about that in glib as well. Basically, in my opinion, the tarball should be complete enough to be a full snapshot of svn at the point of release. Ie it should contain everything that is under source control, even if it is not needed for building from the tarball.
(In reply to comment #16) > I think I complained about that in glib as well. > > Basically, in my opinion, the tarball should be complete enough to be a full > snapshot of svn at the point of release. Ie it should contain everything that > is under source control, even if it is not needed for building from the > tarball. ah, now I understand - and after looking at Makefile.am, I can see the tarball also ships autogen.sh. then yes: po/LINGUAS should go in EXTRA_DIST as well.
Comparing with glib, please add LINGUAS to the DISTFILES variable in po/Makefile.in.in when committing. Thanks.
2008-08-02 Matthias Clasen <mclasen@redhat.com> Bug 344383 – use po/LINGUAS * po/LINGUAS: New file, to make translators happy. * configure.in: Use po/LINGUAS * po/Makefile.in.in: Add po/LINGUAS to DISTFILES Patch by Claude Paroz