GNOME Bugzilla – Bug 341894
Consistent name for home
Last modified: 2012-08-02 03:27:06 UTC
[ forwarded from http://bugs.debian.org/336932 ] The name for the users home folder should be the same as on the desktop. If a user has altered the home_icon_name via gconf the treeview in nautilus tells it still home folder. And in nautilus menu/go/ it's just home. After i accessed it the history in nautilus-menu/go/ tells it like the real folder name. The same applies for gnome-menu/places, but this may be not related to nautilus, i don't know it. All this should be more consistant. This makes it easier for unexperienced users which have problems with all this different names for the same thing. The bug is still present in 2.14. In fact that makes two places where home_icon_name isn't used: the panel and the treeview.
SOunds like inconsistency, however especially unexperienced users will almost certainly not fiddle around with gconf.
One doesn't need to use gconf. Nautilus offers also to rename this from the right-click menu directly on the desktop. And as a site note, i rename my home_icon_name since the german translation is rather ugly and long (Persönlicher Ordner / personal folder). And for windows converters it maybe usefull to rename it to what windows would have called it. This maybe not an argument to a knowledged user, but there are enough dumb users out there - and i wish i could convert my mother to gnome, cause i love it, but with such inconsistencies it's rather harmful to me.
0) consistency In the 2.24.1 desktop for folders with a home icon added (or windows with a small home icon) three names are used out of the box: - Home Folder - $USER's Home - $USER 1) renaming If one changes the name of "$USER's Home" the panel's "Places > Home Folder" will become "Places > $NEW". If one reverts that change it will become "Places > $USER's Home". Only after removing .gconf/apps/nautilus/desktop/%gconf.xml will it be once again the original "Places > Home Folder". (The Places menu in folder windows seem unaffected by all this.)
The Tree side pane uses 'Home Folder', as does the Go menu. The Places side pane and the path bar use the user name. They should all just use 'Home'.
I've just noticed that the home icon on the desktop is named "<user name>'s home" that should also be called the same as everything else: "Home".
When browsing /home/, should my home folder be named "Home" as well?
(In reply to comment #6) > When browsing /home/, should my home folder be named "Home" as well? For reference: http://wiki.ubuntu.com/OneHundredPaperCuts/Spec/382703
(In reply to comment #6) > When browsing /home/, should my home folder be named "Home" as well? No. The various names that have been used for this location in the UI have always been a mask. This bug isn't proposing a radical change from that - just a minor cleanup of terminology.
Created attachment 166190 [details] [review] display name change for home folder
Review of attachment 166190 [details] [review]: Just a quick review, didn't try it out. ::: src/file-manager/fm-directory-view.c @@ +7467,3 @@ G_CALLBACK (action_move_to_next_pane_callback) }, /* name, stock id, label */ {FM_ACTION_COPY_TO_HOME, NAUTILUS_ICON_HOME, + N_("Home"), NULL, Why is the mnemonic removed here? ::: src/nautilus-history-sidebar.c @@ +85,3 @@ sidebar_provider_iface_init)); +char * nautilus_history_sepcial_displayname (char * uri); Typo. sepcial -> special. @@ +94,3 @@ + + ret = NULL; + home_uri = nautilus_get_home_directory_uri(); Missing space. Should be: home_uri = nautilus_get_home_directory_uri (); @@ +127,3 @@ + uri = nautilus_bookmark_get_uri (bookmark); + name = nautilus_history_uri_get_sepcial_displayname (uri); + if (NULL == name) { I think we usually do (name == NULL)
Created attachment 166761 [details] [review] patch based on previou patch
gachen, thanks for your work but could you create a patch that's not based on a previous patch? It gets really hard to see what changes has been made to the original code with patched patches ;) Other than that, here's a few small code style things; > } > >+ >+static char * >+get_special_displayname_for_uri (const char *uri) Try to keep one new line between functions. >+ if (0 == g_strcmp0 (uri,(const char *)home_uri)){ Missing spaces and should probably be the other way around, like this: if (g_strcmp0 (uri, (const char *)home_uri) == 0) { >+ return ret; >+} > char * > nautilus_bookmark_get_name (NautilusBookmark *bookmark) Missing new line between functions. >+ if (name) >+ return name; >+ else >+ return g_strdup (bookmark->details->name); Missing braces. >- uri = nautilus_bookmark_get_uri (bookmark); Is uri still defined? Note: I've not tested the patch and cannot comment if this is right - that's something the real devs has to answer :)
(In reply to comment #11) > Created an attachment (id=166761) [details] [review] > patch based on previou patch gachen, Could you update your patch? [We have User Interface Freeze next week, in Ubuntu, we would like to fix this before that.]
0) bugzilla.gnome.org's interface for submitting patches isn't that great. For example, it's easy to not add the (proposed) commit message to the text of the comment that adds the patch. That forces one to go back and forth between the comments and individual patches. Annoying. (In reply to comment #9) > Created an attachment (id=166190) [details] [review] > display name change for home folder So this is: [PATCH] display name change for home folder change the display name of home folder to "Home" in history/places/tree sidepanes, "Go" menu, and desktop icons fix of error https://bugzilla.gnome.org/show_bug.cgi?id=341894 (In reply to comment #11) > Created an attachment (id=166761) [details] [review] > patch based on previous patch And this is: [PATCH] display name change , "Home Folder" to "Home" 1) The patch added to comment #11 needs a better commit message. 2) Do these patches also address (some or all of) the occurrences of "$USER's Home" and "$USER"?
Created attachment 177565 [details] [review] Display name change for home folder Change the display name of the home folder to "Home" in places/tree sidepanes, "Go" menu, and desktop icons.
Created attachment 177567 [details] [review] Display name change of home folder in history and bookmarks Change the display name of home folder in history list inside the "Go" menu, and in bookmarks.
The patches above in comment #15 and comment #16 should solve this problem properly. The patch in comment #15 addresses all occurrences of "$USER's Home", "Home Folder" and "$USER". The patch in comment #16 changes the display name in the history list in the "Go" menu, and in bookmarks (in the side pane and in the "Bookmarks" menu).
(In reply to comment #17) > The patches above in comment #15 and comment #16 should solve this problem > properly. > Nice work Marcus Husar. Nautilus devs usually do not focus on bug comments.(since it often gets too noisy here on bugzilla). The way to get their attention quicker is to send a mail to nautilus mailing list > http://mail.gnome.org/mailman/listinfo/nautilus-list . Just send a mail requesting review of the patch.
Hi Marcus, thank you very much for the patches! I pushed to master the first patch and a slightly modified version of the second, together with some more naming fixes for the places sidebar. Closing as FIXED.
That doesn't look reasonable to me, please see my comment here: https://bugzilla.gnome.org/show_bug.cgi?id=341135#c13