Bug 336105 – gnome-terminal crashes when termcap not found

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 336105 - gnome-terminal crashes when termcap not found


Summary:	gnome-terminal crashes when termcap not found


Status:	RESOLVED FIXED

Product:	vte
Classification:	Core
Component:	general
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal minor
Target Milestone:	---
Assigned To:	VTE Maintainers
QA Contact:	VTE Maintainers

URL:
Whiteboard:

Duplicates:	341788 348318 397937 (view as bug list)
Depends on:
Blocks:

Reported:	2006-03-26 19:39 UTC by Aivars Kalvans
Modified:	2007-01-31 15:39 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
toss up a gtkmessagedialog (1.50 KB, patch) 2006-09-18 19:45 UTC, Allison Karlitskaya (desrt)	needs-work	Details \| Review
Do not die if termcap==NULL (9.25 KB, patch) 2007-01-17 15:52 UTC, Chris Wilson	none	Details \| Review

Description Aivars Kalvans 2006-03-26 19:39:25 UTC

terminal crashes when file /usr/share/vte/termcap/xterm is not present, it should do some error checking and exit instead.

Program received signal SIGSEGV, Segmentation fault.

+ Trace 67255

Thread NaN (LWP 8573)

#0 _vte_termcap_find_l
at vtetc.c line 493
#1 _vte_termcap_find
at vtetc.c line 579
#2 _vte_termcap_find_string
at vtetc.c line 655
#3 _vte_matcher_init
at matcher.c line 88
#4 _vte_matcher_new
at matcher.c line 216
#5 vte_terminal_set_emulation
at vte.c line 6441
#6 vte_terminal_init
at vte.c line 6723
#7 IA__g_type_create_instance
at gtype.c line 1567
#8 g_object_constructor
at gobject.c line 1015
#9 IA__g_object_newv
at gobject.c line 912
#10 IA__g_object_new_valist
at gobject.c line 955
#11 IA__g_object_new
at gobject.c line 793
#12 vte_terminal_new
at vte.c line 1815
#13 terminal_widget_new
at terminal-widget-vte.c line 65
#14 terminal_screen_init
at terminal-screen.c line 268
#15 IA__g_type_create_instance
at gtype.c line 1567
#16 g_object_constructor
at gobject.c line 1015
#17 IA__g_object_newv
at gobject.c line 912
#18 IA__g_object_new_valist
at gobject.c line 955
#19 IA__g_object_new
at gobject.c line 793
#20 terminal_screen_new
at terminal-screen.c line 463
#21 terminal_app_new_terminal
at terminal.c line 1949
#22 new_terminal_with_options
at terminal.c line 1433
#23 main
at terminal.c line 1761

Comment 1 Fabio Bonelli 2006-05-15 08:20:23 UTC

*** Bug 341788 has been marked as a duplicate of this bug. ***

Comment 2 Fabio Bonelli 2006-07-22 13:08:36 UTC

*** Bug 348318 has been marked as a duplicate of this bug. ***

Comment 3 Allison Karlitskaya (desrt) 2006-09-18 19:45:36 UTC

Created attachment 72997 [details] [review]
toss up a gtkmessagedialog

Comment 4 Behdad Esfahbod 2006-09-18 20:19:05 UTC

Not sure if that's the best action in a widget.

Comment 5 Behdad Esfahbod 2006-09-21 15:25:13 UTC

Also, do we need to add anything like a configure-time check?

Comment 6 Behdad Esfahbod 2006-09-21 15:27:33 UTC

Humm, seems like we already have such a check.

Ryan, I suggest, instead of a dialog etc, we should be forgiving as much as possible, and if all fails, mark a flag and in expose only write with big letters that termcap was not found in "path".

Comment 7 Mariano Suárez-Alvarez 2006-11-16 17:17:00 UTC

Yup, having a widget pop up error dialogs is surely not a good idea.

Behdad's flag and message sounds nice, but one should be very sure that we do not end up checking for the flag too often...

Marking the patch as needing work.

Comment 8 Chris Wilson 2007-01-17 15:52:59 UTC

Created attachment 80517 [details] [review]
Do not die if termcap==NULL

Add checks for termcap==NULL before use and insert an error message into the output stream.

Comment 9 Chris Wilson 2007-01-29 17:16:50 UTC

r1578: 2007-01-29  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 336105 – gnome-terminal crashes when termcap not found

	* src/matcher.c: (_vte_matcher_init):
	* src/vte-private.h:
	* src/vte.c: (vte_terminal_set_default_tabstops),
	(vte_terminal_key_press), (vte_terminal_set_emulation),
	(_vte_terminal_inline_error_message), (vte_terminal_set_termcap),
	(vte_terminal_init), (vte_terminal_finalize),
	(vte_terminal_draw_cells):
		Detect and issue an inline warning when we fail
		to load a termcap.

Comment 10 Chris Wilson 2007-01-29 17:17:12 UTC

*** Bug 397937 has been marked as a duplicate of this bug. ***