After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328241 - id3demux emits NULL date for year tags
id3demux emits NULL date for year tags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 328148 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-23 03:54 UTC by James "Doc" Livingston
Modified: 2006-01-25 04:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description James "Doc" Livingston 2006-01-23 03:54:38 UTC 
When encountering a year id3 tag, id3demux emits a GST_TAG_DATE, however the GDate inside the GstDate is set to NULL. This occurs with the several mp3s I've tested, including old files and newly-tagged ones. This was first noted in bug 309609.

Looking at id3v2_tag_to_taglist [gst-plugins-good/gst/id3demux/id3v2frames.c], seems like it should be working fine, as it's not emitting the warning, but I haven't tried stepping through with gdb to see what is actually happening.
Comment 1 Jan Schmidt 2006-01-23 09:20:07 UTC 
This is probably because the date string from the mp3 only had the year, which the GstDate conversion doesn't handle. I'm about to commit a fix.
Comment 2 Jan Schmidt 2006-01-23 09:49:22 UTC 
Committed. Do you have a GStreamer gst-plugins-good CVS install you can test against?
Comment 3 James "Doc" Livingston 2006-01-23 11:30:59 UTC 
Works for me with a fresh cvs checkout of -good.
Comment 4 Jan Schmidt 2006-01-23 11:58:17 UTC 
Score one for truth and justice then:

        * gst/id3demux/id3tags.c: (id3demux_read_id3v2_tag):
        * gst/id3demux/id3tags.h:
        * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame),
        (parse_comment_frame), (parse_text_identification_frame),
        (id3v2_tag_to_taglist), (id3v2_are_digits),
        (id3v2_genre_string_to_taglist), (id3v2_genre_fields_to_taglist),
        (parse_split_strings), (free_tag_strings):
          Rewrite parsing of text tags to handle multiple NULL terminated
          strings. Parse numeric genre strings and ID3v2 type
          "(3)(6)Alternative" style genre strings.
          Parse dates that are only YYYY or YYYY-mm format.
          (Fixes #328241)
Comment 5 James "Doc" Livingston 2006-01-25 04:31:52 UTC 
*** Bug 328148 has been marked as a duplicate of this bug. ***