GNOME Bugzilla – Bug 326285
Port to GStreamer-0.10
Last modified: 2010-01-24 01:06:15 UTC
The volume applet needs to be ported to GStreamer-0.10. Patch will follow later today.
*** This bug has been marked as a duplicate of 326257 ***
Whoops. Sorry. Reopening bug. Although strongly dependent I can see this isn't an obvious dupe.
Created attachment 57047 [details] [review] patch to port code to GStreamer 0.10 I thought one bug per module would make things easier for the respective module maintainers :) Attached patch ports the mixer applet to GStreamer-0.10. It requires gst-plugins-base from CVS as of today. The patch has not had any testing (as I haven't got a complete 2.13 desktop to test with installed yet).
Created attachment 57374 [details] [review] gnome-applets-2.13.1-gst-010.patch Adds support for building against gstreamer-0.10 without dropping support for gstreamer-0.8
It really does make sense to use gst_audio_default_registry_mixer_filter() for the 0.10 code path, as it handles mixers that do not implement the GstPropertyProbe interface (like e.g. osssink at the moment), which the current code does not.
Ronald says this patch can go in. I assume attachment 57374 [details] [review] is meant to be applied after attachment 57047 [details] [review]. I haven't properly read through this patch, do we need 0.8 backwards compatibility?
No, these are two different patches. * the first patch (mine) only ports to 0.10 without backwards compatibility for 0.8. * the second patch tries to accommodate both 0.8 and 0.10, but at the expense of not using new functionality from 0.10. If you do not see the need to keep 0.8 compatibility, you should only need the first patch (however, someone should really test it first). If you do want to keep 0.8 compatibility, I can create a new patch that cleanly separates the 0.8 and 0.10 code and doesn't have the drawbacks from the second patch. Not quite sure what the point of that is though; if there are any issues with the 0.10 version, they should be fairly easy to fix. If time is a factor, however, the second patch can be applied and should work at least for the most common case (Linux/ALSA) for now.
Some people may want to still use 0.8, other component have a build option, that would be nice to have a patch with both option and the code of the first one imho
I will personally test it tomorrow (although I'm very strapped for time before I fly). What are the new features you are attempting to take advantage of in 0.10 that requires these changes? (I only have the most basic understanding of GStreamer.) 0.8 support while desirable is unlikely to be necessary if the rest of the desktop standardizes on 0.10, but doesn't also have a backwards compatibility option.
Created attachment 57748 [details] [review] gnome-applets-2.13.2-gst-010.patch This updated patch integrates Tim's code into the patch while maintaining backwards compatibility
*** Bug 328786 has been marked as a duplicate of this bug. ***
Tim, Ronald, can I get your thoughts on this latest patch?
Looks good to me (Saleem: thanks for doing the work to combine the patches), but I haven't had a chance to try it yet (my laptop's harddrive with the 2.13 setup just died a few days ago). One minor thing I noticed: in the AC_ARG_WITH(gstreamer,... block in configure.in, the help message should probably be changed from --enable-gstreamer to --with-gstreamer to match the AC_ARG_WITH.
Created attachment 58366 [details] [review] $enableval to $withval to be consistent with AC_ARG_WITH
Should this be gstreamer-plugins-base-0.10 or gstreamer-base-0.10? I don't have the first one available on my system.
This is committed with some reworking of configure.in.