After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326012 - crash in netapplet_set_icon()
crash in netapplet_set_icon()
Status: RESOLVED FIXED
Product: netapplet
Classification: Deprecated
Component: applet
unspecified
Other Linux
: High critical
: ---
Assigned To: Robert Love
Robert Love
: 325235 328368 334012 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-06 18:59 UTC by Christian Kirbach
Modified: 2006-06-20 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch by Roland Kay which handles "Unknown" and prevents crash (1.56 KB, patch)
2006-03-25 14:34 UTC, Christian Kirbach
reviewed Details | Review

Description Christian Kirbach 2006-01-06 18:59:03 UTC
From bug 320241

Comment #8 from gert.vanthienen@skynet.be (points: 1) 
2005-12-22 20:22 UTC [reply] 

Is this wat you wanted?

Backtrace was generated from '/opt/gnome/bin/netapplet'

Using host libthread_db library "/lib/tls/libthread_db.so.1".
`system-supplied DSO at 0xffffe000' has disappeared; keeping its symbols.
[Thread debugging using libthread_db enabled]
[New Thread 1089937504 (LWP 10165)]
0xffffe410 in __kernel_vsyscall ()

Thread 1 (Thread 1089937504 (LWP 10165))

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
    from /lib/tls/libpthread.so.0
  • #2 libgnomeui_module_info_get
    from /opt/gnome/lib/libgnomeui-2.so.0
  • #3 <signal handler called>
  • #4 __kernel_vsyscall
  • #5 raise
    from /lib/tls/libc.so.6
  • #6 abort
    from /lib/tls/libc.so.6
  • #7 g_logv
    from /opt/gnome/lib/libglib-2.0.so.0
  • #8 g_log
    from /opt/gnome/lib/libglib-2.0.so.0
  • #9 g_assert_warning
    from /opt/gnome/lib/libglib-2.0.so.0
  • #10 netapplet_set_icon
    at netapplet.c line 168
  • #11 netapplet_handle_active
    at netapplet.c line 1656
  • #12 netcommon_read_channel
    at netcommon.c line 156
  • #13 g_vasprintf
    from /opt/gnome/lib/libglib-2.0.so.0
  • #14 g_main_context_dispatch
    from /opt/gnome/lib/libglib-2.0.so.0
  • #15 g_main_context_check
    from /opt/gnome/lib/libglib-2.0.so.0
  • #16 g_main_loop_run
    from /opt/gnome/lib/libglib-2.0.so.0
  • #17 gtk_main
    from /opt/gnome/lib/libgtk-x11-2.0.so.0
  • #18 main
    at netapplet.c line 1785
  • #0 __kernel_vsyscall

Comment #9 from gert.vanthienen@skynet.be (points: 1) 
2005-12-22 20:29 UTC [reply] 

I also found these error messages in the terminal window from which I restart
netapplet:

(netapplet:10165): netapplet-WARNING **: icon_name=stock_unknown


netapplet-ERROR **: file netapplet.c: line 168 (netapplet_set_icon): should not
be reached
aborting...
Comment 1 Karsten Bräckelmann 2006-01-29 03:23:39 UTC
*** Bug 328368 has been marked as a duplicate of this bug. ***
Comment 2 Karsten Bräckelmann 2006-01-29 03:25:23 UTC
Confirming as per duplicate.
Comment 3 Roland Kay 2006-03-22 19:07:08 UTC
(Sorry, I filed this against another dup first by mistake).

I think it is very likely that #334012, for which I submitted a patch which
resolves the problem, is a duplicate of this bug.
Comment 4 Christian Kirbach 2006-03-25 14:31:15 UTC
thanks for spotting this duplicate, Roland.
I will attach the patch here so duplicate crash stacktraces can be marked duplicates of this report.

raising priority


Comment 5 Christian Kirbach 2006-03-25 14:32:37 UTC
*** Bug 334012 has been marked as a duplicate of this bug. ***
Comment 6 Christian Kirbach 2006-03-25 14:34:20 UTC
Created attachment 61977 [details] [review]
Patch by Roland Kay which handles "Unknown" and prevents crash

Opened by Roland Kay (points: 2) 
2006-03-09 12:34 UTC [reply] 

Steps to reproduce:
1. Start netdeamon and netapplet
2. Bring up any interface which netapplet cannot identify the type of 
   (in my case a VPN virtual ipsec interface)
3. netapplet will assert and die.
Comment 7 Christian Kirbach 2006-05-18 12:35:55 UTC
some other stacktrace



Backtrace was generated from '/opt/gnome/bin/netapplet'

Using host libthread_db library "/lib/tls/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread 1088849344 (LWP 6708)]
0x4070ddce in __waitpid_nocancel () from /lib/tls/libpthread.so.0

Thread 1 (Thread 1088849344 (LWP 6708))

  • #0 __waitpid_nocancel
    from /lib/tls/libpthread.so.0
  • #1 gnome_init_with_popt_table
    from /opt/gnome/lib/libgnomeui-2.so.0
  • #2 <signal handler called>
  • #3 raise
    from /lib/tls/libc.so.6
  • #4 abort
    from /lib/tls/libc.so.6
  • #5 g_logv
    from /opt/gnome/lib/libglib-2.0.so.0
  • #6 g_log
    from /opt/gnome/lib/libglib-2.0.so.0
  • #7 g_assert_warning
    from /opt/gnome/lib/libglib-2.0.so.0
  • #8 netapplet_set_icon
    at netapplet.c line 168
  • #9 netapplet_handle_active
    at netapplet.c line 1656
  • #10 netcommon_read_channel
    at netcommon.c line 155
  • #11 g_io_channel_unix_get_fd
    from /opt/gnome/lib/libglib-2.0.so.0
  • #12 g_main_context_dispatch
    from /opt/gnome/lib/libglib-2.0.so.0
  • #13 g_main_context_acquire
    from /opt/gnome/lib/libglib-2.0.so.0
  • #14 g_main_loop_run
    from /opt/gnome/lib/libglib-2.0.so.0
  • #15 gtk_main
    from /opt/gnome/lib/libgtk-x11-2.0.so.0
  • #16 main
    at netapplet.c line 1785
  • #0 __waitpid_nocancel
    from /lib/tls/libpthread.so.0

Comment 8 Christian Kirbach 2006-05-18 12:36:12 UTC
*** Bug 325235 has been marked as a duplicate of this bug. ***
Comment 9 Roland Kay 2006-06-14 05:16:42 UTC
Is this applet still under development?

If so, I'm surprised that this bug report is still open given that the cause of the problem is fairly simple and I submitted a patch to solve it three months ago.

If the applet is no longer under development, could I suggest that the bugzilla either be removed or else an obvious notice be added to tell potential contributors that development has ceased. It's only fair to tell people before they volunteer their time.
Comment 10 Christian Kirbach 2006-06-14 12:22:42 UTC
I've just mailed the (former?) maintainer. If nothing happens poke me and I will have it committed.
Comment 11 Christian Kirbach 2006-06-14 12:43:11 UTC
I just saw that a very similar change has been made to cvs - the difference is that it sets a blank tooltip text. It really should fix the same crasher as well.
see http://cvs.gnome.org/viewcvs/netapplet/src/netapplet.c?r1=1.12&r2=1.13

I'll mark this FIXED and leave it to Robert to decide what should appear in the tooltip.

Comment 12 Roland Kay 2006-06-20 14:33:15 UTC
Fantastic.

Thanks for your help.