GNOME Bugzilla – Bug 325966
Clicking folder tree submenu title should open/close the tree
Last modified: 2009-06-13 22:19:10 UTC
I think that when you click on a submenu label in folder tree, evolution should toggle the tree's open/closed (collapsed) state. Now you need to click the small tree icon, and clicking on the tree name does not do anything. In addition following enhancements should be considered - Pressing F2 over a folder name in the tree should allow renaming the folder, just like nautilus does (and not with popup window, but 'inline') - Is there a good action for double clicking folder name? Maybe rename, or mark messages in the folder as read?
hi hile, thanks for taking the time to report these proposals. first one: i don't like this as this fucks up accessibility. think of people not using a mouse, how should they navigate at all through the folder pane? :-/ second one: i personally do not need, but i agree with you for consistency. third one: don't try to link non-obvious actions. no-one would expect all messages to be marked as read when you double-click a folder. :-) anyway, just my personal opinion. note that i am not a developer. i'm going to take care about that F2 issue and added it to http://go-evolution.org/Shortcut_Keys_Review, hopefully we can get this into evolution-2.8. :-)
Heh, what you don't like, that you can't currently browse with keyboard or my suggestion ;) As far as I can see you can _not_ open a subfolder from folder panel at all, at least not with any obvious (tried cursor keys, space, enter) keys. So, if you agree we should maybe even make this accessibility bug as well, in addition to usability bug: only way to open a sub-tree from folder view seems to be now clicking on the small arrow with mouse. So, my suggestion is to make the folder tree open with enter when using keyboard, close with 'whatever-is-the-standard-collapse-tree-key', and in addition my original proposal that the tree node's title should have the behavior of the little arrow as well. I'll add accessibility keyword as well - take it away if you don't think it is appropriate.
hile, To answer your question, it expands on + or Shift+Right key and collapses on '-' or Shift+Left, which Nautilus also does. Pressing F2 is a nice idea, but I doubt the possibility of inline rename. Also Double-Click on a mail folder will refresh the folder, atleast it works the same for me. (Enter also does the same) It doesnt do refresh, if you double click on a ESource name, as it doesnt have any associated actions. That could be a issue... may be...
comments? Is that working for u? reducing the prio to normal
Yes, refresh is the correct action and works as expected for normal folders. Also the keyboard shortcuts to browse the tree work as expected, I just was expecting something different since I don't browse normally trees with keyboard. However, - double-clicking on a subtree (non-folder) node does _not_ actually refresh all folders under this subtree (not a big issue anyway). Maybe it should? - still I think single click on a subtree node should open/close this tree node like firefox does - I'm not sure if this consistent with HIG, and this can't be directly compared to for example nautilus, since there the folder name is _selected_, a tree is valid selection - in evolution selecting a sub tree does not really _mean_ anything.
Hile, The first point may be is fine, but it wont be much intuitive. But I dont prefer doing the second one, as this screws up accessibility and also consistenct across GNOME. Even if this has to be done, this has to be done by GTK only and not Evolution for the *sake* of consistency :) Im marking this bug as enhancement, for implementing *double click* on a non-folder to refresh all subfolders under it.
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
*** Bug 339271 has been marked as a duplicate of this bug. ***
Created attachment 78639 [details] [review] Trivial patch that adds F2 as rename folder accelerator
Updating version to 2.9.x.
Please commit to head.
Committed to head.
Bumping version to a stable release.
Moving this to Mailer.
Closing this as WONTFIX for the following reasons: (In reply to comment #0) > I think that when you click on a submenu label in folder tree, evolution should > toggle the tree's open/closed (collapsed) state. Now you need to click the > small tree icon, and clicking on the tree name does not do anything. This is how tree views work throughout GNOME. We don't want to add custom behavior that users are unfamiliar with. > In addition following enhancements should be considered > - Pressing F2 over a folder name in the tree should allow renaming the > folder, just like nautilus does (and not with popup window, but 'inline') The patch here added the F2 shortcut. The inline rename feature is on my short to-do list. > - Is there a good action for double clicking folder name? Maybe rename, or > mark messages in the folder as read? Too easy to trigger by accident. Initiating a rename would be annoying and marking all mail as read would be destructive.