After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324262 - Problem with dialog when replacing existing files
Problem with dialog when replacing existing files
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Cut Copy Paste Undo
2.13.x
Other All
: Immediate critical
: 2.14.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 324230 324331 324376 325975 326143 326712 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-12-16 12:12 UTC by Sebastien Bacher
Modified: 2006-01-15 11:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
proposed patch by Christian Neumair (7.77 KB, patch)
2005-12-17 13:36 UTC, Christian Kirbach
none Details | Review

Description Sebastien Bacher 2005-12-16 12:12:40 UTC
This bug has been opened here: http://bugzilla.ubuntu.com/show_bug.cgi?id=21079

"In Dapper, when you try to copy files to a folder where a similar files already
exist, you get a dialog like this:

The file "/home/julie...spopup.pyc" already exists.  Would you like to replace it?

If you replace an existing file, its contents will be overwritten.

[Conflict While Copying] [Skip All] [Replace All] [Skip] [Replace]

As you can see, the title of the window (Conflict While Copying) appears in the
first button instead of in the dialog's title bar (which is empty). More over,
pressing "Replace All" will actually act as if you pressed "Skip", and pressing
"Replace" will crash Nautilus, while "Skip All" will actually replace all the
files :)

So I guess there is a problem with the button labels, and the UI organization in
general for this dialog."
Comment 1 Christian Neumair 2005-12-16 13:58:53 UTC
Eeek! Looks like eel and Nautilus are out of sync. This can severely hurt.
Proposed patch:
http://mail.gnome.org/archives/nautilus-list/2005-December/msg00061.html
Comment 2 Sebastien Bacher 2005-12-17 13:00:51 UTC
*** Bug 324331 has been marked as a duplicate of this bug. ***
Comment 3 Sebastien Bacher 2005-12-17 13:08:48 UTC
*** Bug 324230 has been marked as a duplicate of this bug. ***
Comment 4 Christian Kirbach 2005-12-17 13:36:30 UTC
Created attachment 56095 [details] [review]
proposed patch by Christian Neumair
Comment 5 Claudio Saavedra 2005-12-17 15:15:27 UTC
Patch looks good, but I grep'ed and found one omition in
src/nautilus-location-bar.c:

+Index: src/nautilus-location-bar.c
+===================================================================
+RCS file: /cvs/gnome/nautilus/src/nautilus-location-bar.c,v
+retrieving revision 1.109
+diff -u -p -r1.109 nautilus-location-bar.c
+--- src/nautilus-location-bar.c        12 Dec 2005 16:59:11 -0000      1.109
++++ src/nautilus-location-bar.c        17 Dec 2005 15:06:33 -0000
+@@ -167,7 +167,6 @@ drag_data_received_callback (GtkWidget *
+                        GTK_MESSAGE_QUESTION,
+                        prompt,
+                        detail,
+-                       _("View in Multiple Windows?"),
+                        GTK_STOCK_CANCEL, GTK_STOCK_OK,
+                        NULL) != 0 /* GNOME_OK */;
+
Comment 6 Martin Wehner 2005-12-18 01:23:09 UTC
I commited the patch minus the header changes, plus the bit from Claudio. Thanks
guys.
Comment 7 Sebastien Bacher 2005-12-18 18:17:40 UTC
*** Bug 324376 has been marked as a duplicate of this bug. ***
Comment 8 Christian Neumair 2006-01-06 12:46:01 UTC
*** Bug 325975 has been marked as a duplicate of this bug. ***
Comment 9 Christian Neumair 2006-01-08 15:30:26 UTC
*** Bug 326143 has been marked as a duplicate of this bug. ***
Comment 10 Martin Wehner 2006-01-15 11:22:17 UTC
*** Bug 326712 has been marked as a duplicate of this bug. ***