GNOME Bugzilla – Bug 323057
Make podcast support a plugin
Last modified: 2018-05-24 10:55:56 UTC
Version details: 0.9.2 Distribution/Version: Ubuntu Dapper dont display the radio/podcasts sources in the source list, if there are no entries for them, since it is only a waste of space and probably confuses users. Once the User has added a station/ feed, the corresponding item can be displayed again.
I think 'hide the sources when empty' could make these features more diffcult to discover by users. I would recommand to have an option to hide these sources on request if for instance you don't use them.
This will happen when podcast and iradio support get turned into (on by default) plugins. Retitling and changing component.
Also bug #347097 for iradio plugin.
I would quite like to implement this; I have begun writing a plugin in python, using 'feedparser', as suggested[0] on the rhythmbox-devel mailing list in July. [0] http://mail.gnome.org/archives/rhythmbox-devel/2006-July/msg00019.html No meaningful patch yet, though. Hope I'm not duplicating effort.
Here is the feedparser URL: http://feedparser.org/
Created attachment 86691 [details] [review] Fix a bug in the python bindings for do_impl_get_search_actions Copies what do_impl_get_ui_actions does. No currently existing plugin uses this function afaik, so the bug's not been noticed.
Created attachment 86720 [details] [review] Fix up property_view_new in rb.defs Another bit no one else seems to use yet.
Created attachment 86739 [details] Work in progress podcast plugin. This is a snapshot of where I've got to - it's pretty much a direct translation from C into Python. Most of the GUI is implemented, although the append_column_custom() method of RBEntryView needs binding (which could be tricky, as it involves a function pointer). Feeds aren't listed (see bug #431846), but other rhythmdb queries work. Currently it's using the podcast support that's hardcoded into rhythmdb. So far, the PodcastManager class is just a stub.
Is it worth rewriting the whole podcast code from C to python just to make it a plugin? WOuldn't it be easier to just change the existing C code to turn it into a (C) plugin?
I'm hoping to replace the SAX parser with an external Python library, 'feedparser', which will fix a lot of other podcast-related bugs. Along the way, this should make the Python bindings more powerful. It would be possible to do a C plugin first, but imho it doesn't gain you much, apart from being able to hide the source.
Isn't there a feed parser library that could be used without bloating with python? liferea for example has a feed parser. And at least would share the bugs... and the fixes.
Created attachment 86838 [details] Podcast plugin version 0.2 - Put source icon in right place. Remove data directory. - Don't use gobject.new() for source constructor, simplifying things greatly. - Remove shutdown() and add_feed(). - Add more columns to entry view (depends on a fix to bug #432318, coming soon once cleaned up). The previous patches have been obsoleted in favour of fixes to bug #432575 and bug #432228.
What's the status on this? Are you still working on this Tim?
*** Bug 655198 has been marked as a duplicate of this bug. ***
*** Bug 672355 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/97.