GNOME Bugzilla – Bug 322975
erroneous audio specs in flac plugin
Last modified: 2005-12-09 11:13:16 UTC
Version details: 0.9.7 * FLAC supports 1 to 8 channels: http://flac.sourceforge.net/format.html#metadata_block_streaminfo (the plugin specifies 1-6) * FLAC supports the following sampling rates (http://flac.sourceforge.net/format.html#frame_header): 8, 16, 22.05, 24, 32, 44.1, 48 and 96kHz (the plugin specifies a range of 11025Hz-48000Hz). * FLAC supports the following sample sizes, in bits (http://flac.sourceforge.net/format.html#frame_header): 8, 12, 16, 20 and 24 bits (integer), and 32 bits (floating point, although not supported by the reference encoder / decoder) Other less usual sampling rates are also supposed to be supported, although they are outside the scope of the "subset format" (whatever that means - read the docs). Some DVD-Audio mixes are sampled at 88.2kHz, for instance.
Created attachment 55503 [details] [review] Proposed fix Has been successfully tested on 24bit, 96kHz, stereo flac files. Multichannel files somewhat work, although it seems that their higher sampling rate, the more the audio output stutters, as if the buffer wasn't large enough.
Created attachment 55517 [details] [review] Updated patch Here's a fixed patch that actually implements support for the additional depths you added, and for the full range of sampling rates the spec specifies. Not committing yet; we're doing only critical bugfixes before 0.10, so expect this in 0.10.1 unless you can convince others that this is ok. Can you test the patch? I don't have any flac files.
It works on the files I previously tested.
Patch committed; will be in 0.10.1