In addition to this, perhaps F-Spot could do a MD5 sum of the original and the
just copied photo, to ensure that the photo has been correctly copied before
erasing it from the original source.
Or this should be part of the import process?

Anyway, letting F-Spot automatically erase the original photo without confirming
that the copy was successfull is not something I would like to take a chance on

Yes, verifying that the copy was successful ist definetly desirable.

most camera manuals I've seen explicitly say to delete the photos from the camrea using the camera not using the computer.  I'm not sure if there is an actual issue there or not.  It is probably worth chacking with the gphoto developers.

Well, from my (limited) experience with casual users (those who point and shoot), they expected the cameras to be "on the computer". That's what importing is about, otherwise, it's called cloning... I love the idea of doing a fail check on top of that though. But still, maybe some people "want" to keep the pictures on that camera, and we cannot really neglect those, so I'm voting for a checkbox.

line 2:
they expected the *photos* to be "on the computer".

Sorry, my brain is messed up :)

Well, any chance to get this checkbox on import dialog? F-spot is great, but when importing photos, gthumb is much better (cause it removes if required imported photos from camera - it's also using libgphoto2).

*** Bug 343553 has been marked as a duplicate of this bug. ***

(In reply to comment #3)
> most camera manuals I've seen explicitly say to delete the photos from the
> camrea using the camera not using the computer.  I'm not sure if there is an
> actual issue there or not.  It is probably worth chacking with the gphoto
> developers.
> 

Some camera do not support delete. Sony cams in PTP for example.

BTW move can be implemented as download - delete. The safe implementation would download everything and delete what has been safely downloaded.

Most of the p&s cameras owners I know refuse to use f-spot on their linux boxes and windows users just laugh, after finding out, that they have to manually delete imported photos from the camera level.

They mostly say "Hey, what kind of program it is, it forces me to use the camera to manage my photos!"

Maybe, until things don't clear up (Comment #3 from Larry Ewing), it is possible to introduce an option to delete the pics from the camera after importing is completed, in the gconf-editor?

Created attachment 71862 [details] [review]
proposed patch

This bug is really annoying, here is a small fix to get the job done.

I guess I'm just a freak who thinks it's nothing to do with the photo management software to get the photos off the camera.

Regardless, when you stick the card back into your camera, just press format.  It'll save you from any woes of corrupted memory cards down the road too, and means you don't care whether you're photo downloader/manager copied, moved or whatever.

*** Bug 353973 has been marked as a duplicate of this bug. ***

> I guess I'm just a freak who thinks it's nothing to do with the photo
> management software to get the photos off the camera.

You're right, that kind of statement is rather weird.
Get the pictures, clean the card, PP, print -- this is a simply, natural way for the Joe Sixpack.

OK, sorry, that is your way, but not everyone can follow, please read on

> Regardless, when you stick the card back into your camera, just press format.

I never get the card out of the camera (really) nor most of my friends do,
USB is my friend.

Moreover many digicam owners I know do not speak English, so telling them to go to the 'Menu', find 'Playback Menu', then select 'Delete' and then press 'Format Card'
is like talking in Sanskrit.



It is not 'All ya have to do this' feature,
it's an option for the people who badly need this.

If I can add my 2 cent: my "cam" is my mobile phone. It has a nice cam so I use it often to just make a few photos wherever I go, get home and download them to the pc. Sure I could delete the pictures on the phone after that but I would have to delete them on by one because there is no "clear card" option (and I wouldn't want to clear the card, just delete the photos I have on the pc now...)

Right now I always use nautilus to delete those photos but it would be really helpful to have just this option "delete after successful import"

I strongly agree with Michael. We all want desktop that just works.
And finding where is the fucking option to format a memcard (especially our grandmothers or normal users don't want to do that) is not the right way where we should go. Of course, there will be still an option for geeks to not tick the checkbox.

(In reply to comment #15)
> If I can add my 2 cent: my "cam" is my mobile phone. 

And it is supported by libgphoto2?

Who cares? It's just works in gthumb which is using libgphoto2, it's not software for Atomic powerplant.

@Hubert:

It's usb mass storage. I don't know if f-spot uses gphoto2 to access that, all I know is that if I plug in my thone I get a nice dialog asking me if I want to import my photos (if there are any) from the phone. As I don't want them to be archived I say yes and f-spot starts and gives me the import options. I import. Until then this is a *perfect* workflow, a dream come true. But now I have to navigate to the pics folder on the cam using nautilus and delete the photos my hand. And because I don't want them to be moved to .Trash on the phone, I also have to empty the trash. Would be so much easier if f-spot just had an option for this...

(In reply to comment #19)
> @Hubert:
> 
> It's usb mass storage. 
Which phone is it?

Can I get the USB IDs? (for completeness)

It's a Sony Ericsson K750i (Vendor=0xfce / Device=0xd016).
I also use an older Tevion cam sometimes... same there, if 
I connect it to the PC I want to get the photos archived 
and the card cleaned...

*** Bug 346370 has been marked as a duplicate of this bug. ***

The 1st birthday of this bug is coming and still unresolved.
It is very annoying to manually remove few hundreds of photos by hand in camera after import, if I have to leave some pictures on memory card for later use.

*** Bug 385880 has been marked as a duplicate of this bug. ***

I'd really like to install f-spot for my mother. Unfortunately, f-spot's inability to move (rather than copy) photos on import is a blocker. My mother does not understand how to open a file browser, navigate to some subdirectory (she does not even know what a directory or a hierarchical structure is) and delete some pictures (but not the movies that f-spot can't handle anyway).

So pretty please, this is really a no-brainer. If you want f-spot to replace gthumb and the like, there is no way around this enhancement.

I've been playing for some time with gphoto2 and it works perfectly with downloading and _deleting_ files from camera, I don't know why it take so long to implement this _basic_ feature.

(In reply to comment #26)
> I've been playing for some time with gphoto2 and it works perfectly with
> downloading and _deleting_ files from camera, I don't know why it take so long
> to implement this _basic_ feature.
> 

Since it basic, we are waiting for your patch :-)

I'm sure it is basic from a *user* perspective :). But hey, didn't comment #11 contain a patch already?

Well, it's not so easy for me to spend a time for learning another programming language and libgphoto2 API :)

Patch from comment #11 seems not to work and if I remember, checkbox for deleting messages is in main window instead of import dialog. Maybe this is working when importing from another folder, but not from camera.

Ok, I've prepared first path which is working for me. I've tried also add checkbox to import dialog via glade-2 tool, but after regeneration of glade file I have problem with f-spot crash during startup, maybe it need some other changes, but I think it's good point to start.

Regards
Artur 

Created attachment 81629 [details] [review]
First try of deleting files when importing from camera, still without checkbox for optional deleting.

Artur,

here's the trick to avoid the glade issue.

- get a fresh f-spot.glade from svn
- open with glade-2, don't do anything, save the file
- svn diff f-spot.glade > glade.diff
- open f-spot.glade with glade-2, do your modifications, save
- patch -p0 -R < glade.diff
- compile and run

Thx for tips, now it's working for me, maybe it's also working for You :)
Attached complete patch.

Regards
   Artur

Created attachment 81704 [details] [review]
Full patch which adds support for optional removing photos from camera during import

OK, did any one test this patch in own environment?

Just tested it against latest HEAD. Works fine.

Artur could you take a look at your patch? It doesn't apply on current HEAD and 0.4.0

I've changed my camera to DSLR and this patch is not usable for me anymore (my Pentax is now visible as mass storage device) so I'm unable to test it as before. Sorry.

Nah, as far as I know, you can still test it by selecting the folder of the usb mass storage. All my cameras are USB mass storage and I could import photos with f-spot's dialog. Give it a shot!

If I remember correctly, this fix was working only with PTP cameras, not a mass storage (it wasn't implemented).

well couldn't this be adapted slightly so that it does rm on the files? (I don't know if this is the correct way to do it)

Unfortunately I don't have time to maintain this patch, moreover I'm making photos only in RAW, so before importing them to F-Spot I have to do some processing using Rawtherapee (F-Spot lacks many RAW processing features), so import from camera is not important for me :)
I'll look at it at home, but I can't guarantee that it will be working.

Any hope of this every being resolved?  I've been looking at f-spot again since it added the ability to set the base and photo directory, but this bug is still the show stopper.

Created attachment 102404 [details] [review]
UI + code to allow deleting pictures after download

Updated patch, applicable to current SVN trunk.

Created attachment 102405 [details] [review]
Updated, with ChangeLog

Now with a proper ChangeLog entry documenting the changes

Created attachment 102667 [details] [review]
Updated to follow coding style guidelines

*** Bug 510947 has been marked as a duplicate of this bug. ***

The patch doesn't seem to work with Mass Storage Devices for me anyway.  I would like this functionality.  The patch seemed to work ok and the build went well on the head of svn, but I don't see any buttons to check if I want to delete the photos on the camera.  Perhaps it is because the camera I tested behaves as a Mass Storage Device.  Or did I miss something?

Thanks for any help!

Rob

Further report on the patch:

It works fine with a PTP camera.  

Rob

Sad news: pressing "Cancel" at half of the import causes the images to get lost, as they're not imported into f-spot BUT already deleted from the camera!


To be honest, the pictures are saved into f-spot photodir, but not imported in f-spot. But this is another issue (bug 511666)...
That causes also a locking of the camera, but that's another issue (bug 511663)...

Created attachment 103791 [details] [review]
Only delete files after import

This version of the patch only deletes pics from the camera after they've been imported.

Nice feature! I've been waiting for this...

*** Bug 520095 has been marked as a duplicate of this bug. ***

*** Bug 540904 has been marked as a duplicate of this bug. ***

Looking forward to seeing this implemented in f-spot in Ubuntu.

Dont worry. We, CCers are all looking forward to see this implemented (and not only in Ubuntu).

*** Bug 566939 has been marked as a duplicate of this bug. ***

Still not implemented in f-spot 0.5.0.3 (at least for importing from folder / card reader).

Will it see it's 4th anniversary?

*** Bug 603254 has been marked as a duplicate of this bug. ***

Just hit this one myself. Quite annoying. When I plug in my camera and load up f-spot, it's because my camera is full and i want to make room for more! Consequently, I really want to be able to easilly delete everything I import. It's equally important that when it's plugged in, and I only choose a few things to import, that the rest don't dissapear. That's a risk when we're asked to import and then delete in two seperate actions: I can forget what I've imported, and what's still only on the camera, and therefore end up losing data.

Nearly 5 years and we still can't move images.  It's important enough to some to do the work and submit a patch.  I understand it's a hard problem, not wanting to delete images that haven't been moved, but this is one of the most annoying parts of my f-spot work-flow.  Please consider getting this done.

Comment on attachment 71862 [details] [review]
proposed patch

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###

Comment on attachment 81629 [details] [review]
First try of deleting files when importing from camera, still without checkbox for optional deleting.

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###

Comment on attachment 81704 [details] [review]
Full patch which adds support for optional removing photos from camera during import

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###

Comment on attachment 103791 [details] [review]
Only delete files after import

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###

this was implemented in f-spot 0.7.2