After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310370 - crash sometimes on session startup
crash sometimes on session startup
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: stickynotes
git master
Other All
: High normal
: 2.14
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 310896 316544 318299 318526 320195 322970 323860 324792 325106 325530 326619 327011 328482 330814 336615 342135 350832 363356 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-07-14 13:38 UTC by Sebastien Bacher
Modified: 2010-01-24 01:07 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch possibly fixing crash (2.75 KB, patch)
2005-10-07 22:29 UTC, Jaap A. Haitsma
none Details | Review
Patch fixing also desktop click (3.13 KB, patch)
2005-10-14 16:24 UTC, Jaap A. Haitsma
committed Details | Review

Description Sebastien Bacher 2005-07-14 13:38:53 UTC
since 2.11.2 stickynotes crashes sometime on session startup:

Backtrace was generated from '/usr/libexec/stickynotes_applet'

Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1222989600 (LWP 17013)]
0xffffe410 in ?? ()

Thread 1 (Thread -1222989600 (LWP 17013))

  • #0 ??
  • #1 ??
  • #2 ??
  • #3 ??
  • #4 __waitpid_nocancel
    from /lib/tls/i686/cmov/libpthread.so.0
  • #5 libgnomeui_segv_handle
    at gnome-ui-init.c line 749
  • #6 <signal handler called>
  • #7 applet_check_click_on_desktop_cb
    at /build/buildd/gnome-applets-2.11.2/./stickynotes/stickynotes_applet_callbacks.c line 158
  • #8 g_timeout_dispatch
    at gmain.c line 3293
  • #9 g_main_dispatch
    at gmain.c line 1934
  • #10 IA__g_main_context_dispatch
    at gmain.c line 2484
  • #11 g_main_context_iterate
    at gmain.c line 2565
  • #12 IA__g_main_loop_run
    at gmain.c line 2769
  • #13 bonobo_main
    from /usr/lib/libbonobo-2.so.0
  • #14 bonobo_generic_factory_main_timeout
    from /usr/lib/libbonobo-2.so.0
  • #15 bonobo_generic_factory_main
    from /usr/lib/libbonobo-2.so.0
  • #16 panel_applet_factory_main_closure
    at /build/buildd/gnome-panel-2.11.4/./libpanel-applet/panel-applet.c line 1671

Comment 1 Teppo Turtiainen 2005-07-14 15:03:30 UTC
According to simple-dup-finder this is a unique stack trace.
Comment 2 Allison Karlitskaya (desrt) 2005-08-21 04:34:59 UTC
*** Bug 310896 has been marked as a duplicate of this bug. ***
Comment 3 Sebastien Bacher 2005-09-04 09:29:17 UTC
there is an ubuntu bugzilla about that:
http://bugzilla.ubuntu.com/show_bug.cgi?id=14512
Comment 4 Yanko Kaneti 2005-09-19 08:53:08 UTC
This seems to be realted to NAUTILUS_DESKTOP_WINDOW_ID X atom not being set on
time, or not being set at all if nautilus has been removed from the session.

I am bitten by it because I routinely disable nautilus for my gnome session.
Comment 5 Yanko Kaneti 2005-10-06 22:47:46 UTC
I'll take the liberty to add jaap@haitsma.org to the cc list because it seems
this has to to do with the changes introduced in response to #308701
Comment 6 Jaap A. Haitsma 2005-10-07 17:44:01 UTC
Sorry about the bug I  have introduced. I'll try and find out how to solve it.
I'm not completely sure if I can fix it. I'm not very experienced with Gtk and
X. So any help is appreciated
Comment 7 Jaap A. Haitsma 2005-10-07 22:29:02 UTC
Created attachment 53210 [details] [review]
Patch possibly fixing crash

I can't reproduce the crash on my machine, but I think this patch might fix the
crash that people are seeing. Yanko can you try out the patch
Comment 8 Yanko Kaneti 2005-10-08 05:40:59 UTC
Yes, the patch fixes it, thanks.

The way to reporduce the crash is:
# gnome-session-remove nautilus
# gnome-session-save
logout - loging (so that X forgets the atom, don't know if there are ways to do
that from the commandline)
stickynotes crashes on startup if its in the session or crashes when adding it
to the panel if its not in the session.
Comment 9 Jaap A. Haitsma 2005-10-14 16:24:23 UTC
Created attachment 53475 [details] [review]
Patch fixing also desktop click

This patch fixes the crash and also fixes the fact that the notes seemed to
hide auto magically when you were logging in or if you use nautilus in browse
mode and hit the back or forward button.
Comment 10 Jaap A. Haitsma 2005-10-29 21:49:55 UTC
Ping can somebody review (and apply) this patch that fixes a crasher?

Thanks
Comment 11 Danielle Madeley 2005-10-31 02:38:48 UTC
This looks visually clean. I haven't tested it yet.

Earmarked for 2.12.2 and 2.13.
Comment 12 Jaap A. Haitsma 2005-11-14 22:28:28 UTC
Ping.

Would be nice if this could go in before 2.13.2 (release today) and 2.12.2(in 14
days)
Comment 13 Danielle Madeley 2005-11-15 02:12:29 UTC
Ok. This looks good. It no longer crashes when Nautilus isn't running, of
course, there is no way to make the notes vanish when Nautilus isn't running.

Stickynotes also do not remember their state when the applet is restarted
(whether they were hidden or showing).
Comment 14 Danielle Madeley 2005-11-15 02:21:54 UTC
Ok. This is committed to HEAD. I will look at backporting it in a couple of weeks.
Comment 15 Jaap A. Haitsma 2005-11-15 18:34:10 UTC
> Ok. This looks good. It no longer crashes when Nautilus isn't running, of
> course, there is no way to make the notes vanish when Nautilus isn't running.

Maybe add a hide notes menu item to the context menu???


> Stickynotes also do not remember their state when the applet is restarted
> (whether they were hidden or showing)

Always showing them on startup is actually a desired feature (at least for me).
That way everytime I start up my PC I get reminded of things I should do.
Furthermore it's very easy to move them out of your sight. By just launching an
app or clicking on the desktop.

Backporting should not really be a problem. If I remember correctly it applies
cleanly on 2.12
Comment 16 Sebastien Bacher 2005-11-15 21:06:50 UTC
> Always showing them on startup is actually a desired feature (at least for me).

As a note, that's the reason which made me switch to tomboy on month ago, I have
quite a lot of note and it's pretty annoying to have to click on the desktop
every time on startup to mask them. It's also annoying if you hack on the panel
and restart it quite often to try changes
Comment 17 Jaap A. Haitsma 2005-11-15 21:17:15 UTC
OK I guess it depends on how you use it. I guess the best solution is to have 
sticky notes remember if it was visible or not and have a checkbox in the
preferences for people like me who want them visible at startup.


Comment 18 Danielle Madeley 2005-11-16 02:46:14 UTC
Yeah. Restarting the panel made me comment on it.

That is a simple enough feature that it could have a check box in the UI.

 [X] Always show sticky notes on startup

It could be on by default. A hide option in the context menu is also a good
idea. We should keep the minimise animation when you use the context menu hide also.
Comment 19 Sebastien Bacher 2005-11-20 14:59:52 UTC
*** Bug 318526 has been marked as a duplicate of this bug. ***
Comment 20 Sebastien Bacher 2005-11-20 15:00:25 UTC
*** Bug 318299 has been marked as a duplicate of this bug. ***
Comment 21 Jaap A. Haitsma 2005-11-29 08:01:16 UTC
David as I'm seeing 2.12.2 tarballs coming out, just a reminder to apply this
patch to 2.12.2
Comment 22 Danielle Madeley 2005-11-29 09:44:28 UTC
It should have been. Can you confirm for me please?
Comment 23 Jaap A. Haitsma 2005-11-29 21:32:14 UTC
Confirmed it's there
Comment 24 Teppo Turtiainen 2005-12-02 17:55:21 UTC
*** Bug 322970 has been marked as a duplicate of this bug. ***
Comment 25 Danielle Madeley 2005-12-21 06:03:54 UTC
Marking as a possible target for gnome-love and retitling to capture the two new requirements of the bug:

 1. Have an option in the menu to hide all of the stickynotes;
 2. Have an option in the preferences to show all of the stickynotes on load
Comment 26 Danielle Madeley 2005-12-21 07:48:17 UTC
Found out that at least half of this is a duplicate of #310246. Closing this bug, since it is long and really, actually unrelated.
Comment 27 Danielle Madeley 2005-12-21 08:11:31 UTC
*** Bug 323860 has been marked as a duplicate of this bug. ***
Comment 28 Christian Kirbach 2005-12-22 14:43:28 UTC
*** Bug 324792 has been marked as a duplicate of this bug. ***
Comment 29 Danielle Madeley 2005-12-28 07:48:38 UTC
*** Bug 325106 has been marked as a duplicate of this bug. ***
Comment 30 Christian Kirbach 2006-01-02 16:39:29 UTC
*** Bug 325530 has been marked as a duplicate of this bug. ***
Comment 31 Danielle Madeley 2006-01-11 04:40:26 UTC
*** Bug 316544 has been marked as a duplicate of this bug. ***
Comment 32 Danielle Madeley 2006-01-11 04:41:26 UTC
*** Bug 320195 has been marked as a duplicate of this bug. ***
Comment 33 Danielle Madeley 2006-01-12 04:07:45 UTC
*** Bug 326619 has been marked as a duplicate of this bug. ***
Comment 34 Danielle Madeley 2006-01-15 03:20:03 UTC
*** Bug 327011 has been marked as a duplicate of this bug. ***
Comment 35 Karsten Bräckelmann 2006-01-29 03:16:52 UTC
*** Bug 328482 has been marked as a duplicate of this bug. ***
Comment 36 Karsten Bräckelmann 2006-02-11 19:14:04 UTC
*** Bug 330814 has been marked as a duplicate of this bug. ***
Comment 37 Karsten Bräckelmann 2006-03-30 14:21:42 UTC
*** Bug 336615 has been marked as a duplicate of this bug. ***
Comment 38 Fabio Bonelli 2006-05-17 15:27:30 UTC
*** Bug 342135 has been marked as a duplicate of this bug. ***
Comment 39 Christian Kirbach 2006-08-11 09:33:35 UTC
*** Bug 350832 has been marked as a duplicate of this bug. ***
Comment 40 Karsten Bräckelmann 2006-10-19 10:09:13 UTC
*** Bug 363356 has been marked as a duplicate of this bug. ***