After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 302204 - Maximize-vertically short cut acts as maximize
Maximize-vertically short cut acts as maximize
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.10.x
Other All
: High minor
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
: 167251 308292 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-04-27 18:05 UTC by avitzour
Modified: 2005-06-19 15:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Attempt to fix vertical maximization acting as complete maximization (1.16 KB, patch)
2005-04-27 20:02 UTC, Elijah Newren 		accepted-commit_now Details | Review

Description avitzour 2005-04-27 18:05:45 UTC 
Please describe the problem:
When the window to be vertically-maximized is touching the right edge of screen,
using the maximize vertically shortcut maximizes the window completely. Using
then the unmaximize option brings the window to the desired vertically maximized
window.
Using the shortcut when the window is not touching the right edge works fine.
The bug is independent of the actual shortcut chosen for maximize vertically
(tried both <control>-Up and <Shift><Control>-U)

This bug was not present in previous version (2.8 and down)

Steps to reproduce:
1. Select a window
2. Drag it so that the right edge touches the edge of the screen
3. Use maximize-vertically shortcut


Actual results:
The window maximizes completely

Expected results:
The window should maximize only vertically

Does this happen every time?
Yes

Other information:
Comment 1 Elijah Newren 2005-04-27 20:01:57 UTC 
Caused by the patch in bug 163420 (though the original code was wrong too, so we
just had a bug exchange).  It took me a while to attempt to understand the logic
of the 'if' statement in check_maximize_to_work_area(), so I put a huge comment
in front of it stating what I think it is meant to do.  I'll attach the patch in
a minute and it seems to work for me, but considering that this code has been
messed up a few times before, I'd appreciate some close scrutiny.  :-)

(Also, I think bug 167251 is a duplicate, but I'm not sure...)
Comment 2 Elijah Newren 2005-04-27 20:02:41 UTC 
Created attachment 45753 [details] [review]
Attempt to fix vertical maximization acting as complete maximization
Comment 3 Elijah Newren 2005-05-26 17:07:32 UTC 
Havoc: ping.  (It's been reported that this patch fixes bug 167251 as well...)
Comment 4 Elijah Newren 2005-05-26 17:08:03 UTC 
*** Bug 167251 has been marked as a duplicate of this bug. ***
Comment 5 Havoc Pennington 2005-05-26 18:33:48 UTC 
Comment on attachment 45753 [details] [review]
Attempt to fix vertical maximization acting as complete maximization

Looks right to me. I guess this never worked at all...
Comment 6 Elijah Newren 2005-05-26 18:43:23 UTC 
Committed.

avitzour@princeton.edu: Thanks for the level of detail in this bug; it was
because of that detail that I was able to easily duplicate and then track down.  ;-)
Comment 7 Elijah Newren 2005-06-19 15:43:40 UTC 
*** Bug 308292 has been marked as a duplicate of this bug. ***