After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166620 - [patch] use gtkAboutDialog
[patch] use gtkAboutDialog
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
: 156150 167084 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-02-08 01:04 UTC by Kristof Vansant
Modified: 2005-04-12 05:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
use GTKABOUTDIALOGWIDGET (2.85 KB, patch)
2005-02-08 01:16 UTC, Kristof Vansant 		none Details | Review

Description Kristof Vansant 2005-02-08 01:04:02 UTC 
Please describe the problem:
use the new gtk aboutdialog widget



Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Kristof Vansant 2005-02-08 01:16:28 UTC 
Created attachment 37139 [details] [review]
use GTKABOUTDIALOGWIDGET
Comment 2 Christian Persch 2005-02-14 23:24:12 UTC 
+ "translator-credits",(strcmp (translators, "translator-credits") ? translators
: NULL),


That's unnecessary, since gtk+ does that check itself; it only displays
translator credits if the string is != translator-credits.
Comment 3 Paolo Borelli 2005-02-15 14:15:58 UTC 
*** Bug 167084 has been marked as a duplicate of this bug. ***
Comment 4 Paolo Borelli 2005-02-15 14:18:45 UTC 
(note that also bug 167084 contains a similar patch... I have not checked if one
is better than the other)
Comment 5 Vincent Noel 2005-02-15 14:29:11 UTC 
The patch from Kristof (attachment 37139 [details] [review]) is actually better, as it changes the
GNOME_STOCK_ABOUT that I did not notice :)
Comment 6 Paolo Borelli 2005-02-15 14:54:37 UTC 
*** Bug 156150 has been marked as a duplicate of this bug. ***
Comment 7 Kristof Vansant 2005-02-15 16:49:30 UTC 
looking at bug 156150
I forgot:
-GTK_REQUIRED=2.4.0
+GTK_REQUIRED=2.5.0

in configure.in

ps: wouldn't it be better to set 2.6.0 to be safe because I don't know for sure
that an experimental gtkabout widget was introduced in the 2.5.0 version.
Does anyone know in which version it was?
Comment 8 Kristof Vansant 2005-03-26 02:42:16 UTC 
why is it still not commited? plz give some feedback
Comment 9 Kristof Vansant 2005-04-03 20:22:39 UTC 
why was this keyword set?

PATCH   	This keyword is deprecated and will be removed at a future date. It is
also useless since many patches do not have this keyword set at all. Patches
should now be found by querying bugzilla for attachment statuses.  	 7029
Comment 10 Jens Finke 2005-04-04 05:34:17 UTC 
Because I am querying for it to find patches. Didn't know about the attachment
status thing.
Comment 11 Jens Finke 2005-04-12 05:23:06 UTC 
Applied to head. Thanks for your patients.