After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165533 - Show Progress bar in the main window itself
Show Progress bar in the main window itself
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: interface
git master
Other Linux
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
: 142707 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-01-28 18:36 UTC by Madhan Raj M
Modified: 2005-07-14 10:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Snap shot of the changes (77.88 KB, image/png)
2005-01-28 18:44 UTC, Madhan Raj M
  Details
While extracting, the "Extract" label has been changed to "Cancel" (109.65 KB, image/png)
2005-01-30 16:15 UTC, Madhan Raj M
  Details
Change the "Cancel" label back to "Extract" when extract is clicked (99.23 KB, image/png)
2005-01-30 16:25 UTC, Madhan Raj M
  Details
Patch for the changes against CVS HEAD (36.41 KB, patch)
2005-02-01 16:58 UTC, Madhan Raj M
none Details | Review
Snapshot (64.28 KB, image/png)
2005-03-31 09:14 UTC, Madhan Raj M
  Details
Snapshop, when ripping finishes one track (64.28 KB, image/png)
2005-03-31 09:15 UTC, Madhan Raj M
  Details
snapshot when ripping is cancelled (57.88 KB, image/png)
2005-03-31 09:16 UTC, Madhan Raj M
  Details
Snapshot while extracting Progress bar along with the status bar (40.42 KB, image/png)
2005-06-30 17:08 UTC, Madhan Raj M
  Details
Extraction cancelled (36.05 KB, image/png)
2005-06-30 17:09 UTC, Madhan Raj M
  Details
Snapshot for the sj-player-branch head source (46.33 KB, image/png)
2005-07-01 16:22 UTC, Madhan Raj M
  Details
Patch against the sj-player-branch (25.55 KB, patch)
2005-07-01 18:25 UTC, Madhan Raj M
none Details | Review
Patch against the CVS HEAD (27.76 KB, patch)
2005-07-03 07:23 UTC, Madhan Raj M
none Details | Review
Snapshot while extracting (41.82 KB, image/png)
2005-07-03 07:24 UTC, Madhan Raj M
  Details
Snapshot while extracting (42.04 KB, image/png)
2005-07-04 10:52 UTC, Madhan Raj M
  Details
Snapshot when Extraction is cancelled (39.07 KB, image/png)
2005-07-04 10:56 UTC, Madhan Raj M
  Details
Latest patch against CVS HEAD (30.05 KB, patch)
2005-07-04 11:33 UTC, Madhan Raj M
needs-work Details | Review
Updated patch (29.96 KB, patch)
2005-07-04 18:35 UTC, Madhan Raj M
none Details | Review
Updated Patch against CVS HEAD (28.51 KB, patch)
2005-07-14 07:02 UTC, Madhan Raj M
none Details | Review

Description Madhan Raj M 2005-01-28 18:36:43 UTC
Reasons for this Changes: 
1. Instead of poping up a seperate progress window, the progress could be shown 
in the main windows itself for each track. 
 
2. This improves the user friendliness as the user will know the status of the 
Extraction process, ie how many tracks have been ripped and how many is still 
remaining. 
 
3. The user also can see the percentage ripped so far.
Comment 1 Madhan Raj M 2005-01-28 18:44:33 UTC
Created attachment 36665 [details]
Snap shot of the changes

Snap shot showing the progress bar for each track.
Comment 2 Madhan Raj M 2005-01-30 16:15:58 UTC
Created attachment 36724 [details]
While extracting, the "Extract" label has been changed to "Cancel"

A new label added to show the Remaining time and speed
Comment 3 Madhan Raj M 2005-01-30 16:25:23 UTC
Created attachment 36727 [details]
Change the "Cancel" label back to "Extract" when extract is clicked
Comment 4 Madhan Raj M 2005-02-01 16:58:18 UTC
Created attachment 36828 [details] [review]
Patch for the changes against CVS HEAD
Comment 5 Ross Burton 2005-02-06 17:00:42 UTC
*** Bug 142707 has been marked as a duplicate of this bug. ***
Comment 6 Ross Burton 2005-02-06 17:03:50 UTC
My vision:

When Extract is pressed, the Extract button becomes Cancel, the status bar
reports the overall percentage complete and estimated time remaining, and each
track is highlighted as it is extracted.  Maybe bold the current extracting
track, add a small icon, or fade (disable) the completed and not to be ripped
tracks.
Comment 7 Dave Neary 2005-02-07 08:07:40 UTC
You could try looking at the code in the GIMP (added during the 2.2 development
cycle) which did just this.

Dave.
Comment 8 Madhan Raj M 2005-02-11 12:07:53 UTC
Ross: when the track_listview is made insensitive, and when an icon is 
displayed to indicate the current ripping track.. the icon is grayed out. 
Should i let that like that or i need to make that specific column 
sensitive...  
Comment 9 Madhan Raj M 2005-03-31 08:49:51 UTC
Am working on it. 
Done:
1. Current ripping task is indicated by a gtk-cdrom icon, finished track by
gtk-apply icon, and cancelled track by gtk-cancel icon.

2. The progress dialog is removed and brought to the main UI and shows the
progress of the current track.

3. Overall ripping status is shown in the status bar.

Remaining Taks:
1. To bold the current ripping track.
Comment 10 Madhan Raj M 2005-03-31 09:14:34 UTC
Created attachment 39485 [details]
Snapshot

Snapshot - When sj starts ripping
Comment 11 Madhan Raj M 2005-03-31 09:15:27 UTC
Created attachment 39486 [details]
Snapshop, when ripping finishes one track
Comment 12 Madhan Raj M 2005-03-31 09:16:07 UTC
Created attachment 39487 [details]
snapshot when ripping is cancelled
Comment 13 Ross Burton 2005-03-31 09:22:46 UTC
Try putting the progress bar in the status bar -- GnomeApp does this so it
should be quit easy.  I also noticed that the icons are faded, I presume this is
due to the GtkTreeView being disabled.  I wonder if this can be avoided.
Comment 14 Christophe Fergeau 2005-03-31 09:31:07 UTC
Should the progress bar correspond to the current track rip progress, or to the
overall rip progress?
Comment 15 Ross Burton 2005-03-31 09:36:06 UTC
My current idea is a single progress bar, in the status bar, which shows the
overall progress.
Comment 16 Madhan Raj M 2005-03-31 09:52:02 UTC
Thanks Ross for the comment :)
Comment 17 Madhan Raj M 2005-06-30 17:08:45 UTC
Created attachment 48461 [details]
Snapshot while extracting
Progress bar along with the status bar

The progress bar indicates the total progress time and it has been placed along
with the status bar.
Using GnomeApp, the same kind of progress bar and status bar can be got, but
GnomeApp used many deprecated functions. So, a seperate progress bar and status
bar is used.

TODO:
1. To enable the Pixbuf column while extracting
2. To Highlight the current extracting column
Comment 18 Madhan Raj M 2005-06-30 17:09:40 UTC
Created attachment 48462 [details]
Extraction cancelled
Comment 19 Ross Burton 2005-06-30 17:18:55 UTC
Oh cool.

If you want to be my *best friend ever*, start to merge this with the work in
the "sj-player-branch" CVS branch of Sound Juicer.

The contents of that branch will be HEAD shortly.
Comment 20 Madhan Raj M 2005-06-30 17:27:30 UTC
Sure, i love to,.. ;)
Comment 21 Madhan Raj M 2005-07-01 16:22:38 UTC
Created attachment 48508 [details]
Snapshot for the sj-player-branch head source
Comment 22 Madhan Raj M 2005-07-01 18:25:23 UTC
Created attachment 48518 [details] [review]
Patch against the sj-player-branch
Comment 23 Madhan Raj M 2005-07-03 07:23:11 UTC
Created attachment 48579 [details] [review]
Patch against the CVS HEAD

1. The progress dialog has been removed and brought to the main UI
2. The sensitivity of the track_listview is not disabled while extration and
the Extract column alone is made INERT while extraction is in progress. This is
done so that, the Stock item is seen clearly while extracting
3. on_tracklist_row_activate handler is blocked while extraction is in
progress.
Comment 24 Madhan Raj M 2005-07-03 07:24:31 UTC
Created attachment 48580 [details]
Snapshot while extracting
Comment 25 Madhan Raj M 2005-07-04 10:52:43 UTC
Created attachment 48612 [details]
Snapshot while extracting
Comment 26 Madhan Raj M 2005-07-04 10:56:14 UTC
Created attachment 48613 [details]
Snapshot when Extraction is cancelled

Ross:
 I have used GTK-APPLY to indicate that a track has been ripped successfully,
and GTK-CANCEL, if any error occurs or Extraction is cancelled.
GTK_STOCK_MEDIA_RECORD	would indicate the ripping track. Is this behaviour OK
?
Comment 27 Ross Burton 2005-07-04 11:04:45 UTC
Not sure about an icon for ripped songs...  leave it in for now as long as all
state is restored so there are no icons once the rip is complete.

Can you attach your latest patch?
Comment 28 Madhan Raj M 2005-07-04 11:33:18 UTC
Created attachment 48619 [details] [review]
Latest patch against CVS HEAD
Comment 29 Ross Burton 2005-07-04 15:03:49 UTC
...
label = gtk_label_get_text (extract_label);
if (!(strcmp (label, "Stop"))) {
...

That won't work in any locale other than the one you write that compare in, so
won't work.

Why not use a static gboolean in sj-extracting.c?  And to re-label a button at
runtime see cb_state() in sj-play.c.
Comment 30 Madhan Raj M 2005-07-04 18:35:44 UTC
Created attachment 48642 [details] [review]
Updated patch

Ross, The re-label cannot be done as per cb_state in sj-play.c
Since, there the Play and Pause label are used which can be changed by just
changing the Stock Item.
But, for GTK_STOCK_CDROM, we need to set "Extract" label.
GTK_STOCK_STOP can be used to set the label "Stop", but using this makes it
difficult to change the label to "Extract"
So, as in the patch, the re-label has been done at run time
Comment 31 Madhan Raj M 2005-07-08 07:27:27 UTC
Ross: 
Should i have to create a new Gtk Stock Item for Extract button. Then it can be
done as you said.
Comment 32 Ross Burton 2005-07-13 11:53:54 UTC
SJ in CVS now has a stock item factory.
Comment 33 Ross Burton 2005-07-13 13:12:35 UTC
SJ in CVS now has SJ_STOCK_EXTRACT for the extract button.
Comment 34 Madhan Raj M 2005-07-14 07:02:46 UTC
Created attachment 49149 [details] [review]
Updated Patch against CVS HEAD

Updated patch using the SJ stock items
Comment 35 Ross Burton 2005-07-14 10:36:29 UTC
Rock on!

I like how the final patch is about half the size of the first one. :)

Committed to HEAD.